Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile on win Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
index eb3e2ae7a22609c6bd36140b3c7252ae056c1c47..aa30bf47da89859f9f7c03a754f711557070e74f 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8InspectorClient.h
@@ -5,7 +5,8 @@
#ifndef V8InspectorClient_h
#define V8InspectorClient_h
-#include "platform/inspector_protocol/InspectorProtocol.h"
+#include "platform/v8_inspector/public/StringBuffer.h"
+#include "platform/v8_inspector/public/StringView.h"
#include <v8.h>
@@ -29,7 +30,7 @@ public:
virtual void beginUserGesture() { }
virtual void endUserGesture() { }
- virtual String16 valueSubtype(v8::Local<v8::Value>) { return String16(); }
+ virtual std::unique_ptr<StringBuffer> valueSubtype(v8::Local<v8::Value>) { return nullptr; }
virtual bool formatAccessorsAsProperties(v8::Local<v8::Value>) { return false; }
virtual bool isInspectableHeapObject(v8::Local<v8::Object>) { return true; }
@@ -38,12 +39,12 @@ public:
virtual void endEnsureAllContextsInGroup(int contextGroupId) { }
virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) { }
- virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) { }
+ virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, const StringView& message, const StringView& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) { }
virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) { return v8::MaybeLocal<v8::Value>(); }
- virtual void consoleTime(const String16& title) { }
- virtual void consoleTimeEnd(const String16& title) { }
- virtual void consoleTimeStamp(const String16& title) { }
+ virtual void consoleTime(const StringView& title) { }
+ virtual void consoleTimeEnd(const StringView& title) { }
+ virtual void consoleTimeStamp(const StringView& title) { }
virtual double currentTimeMS() { return 0; }
typedef void (*TimerCallback)(void*);
virtual void startRepeatingTimer(double, TimerCallback, void* data) { }

Powered by Google App Engine
This is Rietveld 408576698