Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile on win Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
index 25ad3ab09d6120bb8d1c1105a68b2aec7b4c1ae9..2795cb4ca630a85205572cf47d7e25a2000d9c33 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h
@@ -64,13 +64,13 @@ public:
// V8StackTrace implementation.
bool isEmpty() const override { return !m_frames.size(); };
- String16 topSourceURL() const override;
+ StringView topSourceURL() const override;
int topLineNumber() const override;
int topColumnNumber() const override;
- String16 topScriptId() const override;
- String16 topFunctionName() const override;
+ StringView topScriptId() const override;
+ StringView topFunctionName() const override;
std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject() const override;
- String16 toString() const override;
+ std::unique_ptr<StringBuffer> toString() const override;
private:
V8StackTraceImpl(int contextGroupId, const String16& description, std::vector<Frame>& frames, std::unique_ptr<V8StackTraceImpl> parent);

Powered by Google App Engine
This is Rietveld 408576698