third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: compile on win Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Debugger.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/StringView.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

index 160ec7417df6b9de8c59f15616b9fceeb02bfb02..ae7967d9d5a9690652ca96a402d95259e399b23f 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

@@ -331,7 +331,7 @@ std::unique_ptr<V8ConsoleMessage> V8ConsoleMessage::createForConsoleAPI(double t

{

std::unique_ptr<V8ConsoleMessage> message = wrapUnique(new V8ConsoleMessage(V8MessageOrigin::kConsole, timestamp, String16()));

if (stackTrace && !stackTrace->isEmpty()) {

- message->m_url = stackTrace->topSourceURL();

+ message->m_url = toString16(stackTrace->topSourceURL());

message->m_lineNumber = stackTrace->topLineNumber();

message->m_columnNumber = stackTrace->topColumnNumber();

}

@@ -354,7 +354,7 @@ std::unique_ptr<V8ConsoleMessage> V8ConsoleMessage::createForConsoleAPI(double t

clientType = V8ConsoleAPIType::kInfo;

else if (type == ConsoleAPIType::kClear)

clientType = V8ConsoleAPIType::kClear;

- context->inspector()->client()->consoleAPIMessage(context->contextGroupId(), clientType, message->m_message, message->m_url, message->m_lineNumber, message->m_columnNumber, message->m_stackTrace.get());

+ context->inspector()->client()->consoleAPIMessage(context->contextGroupId(), clientType, toStringView(message->m_message), toStringView(message->m_url), message->m_lineNumber, message->m_columnNumber, message->m_stackTrace.get());

return message;

}