third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template - Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: small fixes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/V8InspectorString.cpp ('K') | « third_party/WebKit/Source/platform/inspector_protocol/Parser_h.template ('k') | third_party/WebKit/Source/platform/inspector_protocol/String16_h.template » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template

index d795aefa0c2f2549eb44bc2ac12e1dd38f4527ef..dd411f75afabe6181757d243ce567e6676d22bc5 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/String16_cpp.template

@@ -31,15 +31,6 @@ void doubleToStr6(double number, char* buffer, size_t length)

std::snprintf(buffer, length, "%.6g", number);

}

-double strToDouble(const char* buffer, bool* ok)

- char* endptr;

- double result = std::strtod(buffer, &endptr);

- if (ok)

- *ok = !(*endptr);

- return result;

int strToInt(const char* buffer, bool* ok)

{

char* endptr;