[DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}.

third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/inspector/InspectorAnimationAgent.h"
 
 #include "core/animation/Animation.h"
 #include "core/animation/AnimationEffectReadOnly.h"
 #include "core/animation/AnimationEffectTiming.h"
 #include "core/animation/ComputedTimingProperties.h"
 #include "core/animation/EffectModel.h"
 #include "core/animation/ElementAnimation.h"
 #include "core/animation/KeyframeEffect.h"
 #include "core/animation/KeyframeEffectModel.h"
 #include "core/animation/StringKeyframe.h"
 #include "core/css/CSSKeyframeRule.h"
 #include "core/css/CSSKeyframesRule.h"
 #include "core/css/CSSRuleList.h"
 #include "core/css/CSSStyleRule.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/DOMNodeIds.h"
 #include "core/dom/NodeComputedStyle.h"
 #include "core/frame/LocalFrame.h"
 #include "core/inspector/InspectedFrames.h"
 #include "core/inspector/InspectorCSSAgent.h"
 #include "core/inspector/InspectorDOMAgent.h"
 #include "core/inspector/InspectorStyleSheet.h"
+#include "core/inspector/V8InspectorStringView.h"
 #include "platform/Decimal.h"
 #include "platform/animation/TimingFunction.h"
 #include "platform/v8_inspector/public/V8InspectorSession.h"
 #include "wtf/text/Base64.h"
 #include <memory>
 
 namespace AnimationAgentState {
 static const char animationAgentEnabled[] = "animationAgentEnabled";
 static const char animationAgentPlaybackRate[] = "animationAgentPlaybackRate";
 }
 
 namespace blink {
 
+static const char animationObjectGroup[] = "animation";

[caseq, 2016/08/19 21:57:02]

please move it into function that needs it, or use anonymous namespace if you
need to share it between functions.

[dgozman, 2016/08/20 02:04:51]

Done.

+
 InspectorAnimationAgent::InspectorAnimationAgent(InspectedFrames* inspectedFrames, InspectorDOMAgent* domAgent, InspectorCSSAgent* cssAgent, v8_inspector::V8InspectorSession* v8Session)
     : m_inspectedFrames(inspectedFrames)
     , m_domAgent(domAgent)
     , m_cssAgent(cssAgent)
     , m_v8Session(v8Session)
     , m_isCloning(false)
 {
 }
 
 void InspectorAnimationAgent::restore()
@@ skipping 315 matching lines @@
     const Element* element = toKeyframeEffect(animation->effect())->target();
     Document* document = element->ownerDocument();
     LocalFrame* frame = document ? document->frame() : nullptr;
     ScriptState* scriptState = frame ? ScriptState::forMainWorld(frame) : nullptr;
     if (!scriptState) {
         *errorString = "Element not associated with a document.";
         return;
     }
 
     ScriptState::Scope scope(scriptState);
-    m_v8Session->releaseObjectGroup("animation");
-    *result = m_v8Session->wrapObject(scriptState->context(), toV8(animation, scriptState->context()->Global(), scriptState->isolate()), "animation");
+    m_v8Session->releaseObjectGroup(toV8InspectorStringView(animationObjectGroup));
+    *result = m_v8Session->wrapObject(scriptState->context(), toV8(animation, scriptState->context()->Global(), scriptState->isolate()), toV8InspectorStringView(animationObjectGroup));
     if (!*result)
         *errorString = "Element not associated with a document.";
 }
 
 static CSSPropertyID animationProperties[] = {
     CSSPropertyAnimationDelay,
     CSSPropertyAnimationDirection,
     CSSPropertyAnimationDuration,
     CSSPropertyAnimationFillMode,
     CSSPropertyAnimationIterationCount,
@@ skipping 100 matching lines @@
 {
     visitor->trace(m_inspectedFrames);
     visitor->trace(m_domAgent);
     visitor->trace(m_cssAgent);
     visitor->trace(m_idToAnimation);
     visitor->trace(m_idToAnimationClone);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink