Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8ContextInfo.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8ContextInfo_h 5 #ifndef V8ContextInfo_h
6 #define V8ContextInfo_h 6 #define V8ContextInfo_h
7 7
8 #include "platform/inspector_protocol/InspectorProtocol.h" 8 #include "platform/v8_inspector/public/StringView.h"
9 9
10 #include <v8.h> 10 #include <v8.h>
11 11
12 namespace v8_inspector { 12 namespace v8_inspector {
13 13
14 class V8ContextInfo { 14 class V8ContextInfo {
esprehn 2016/08/19 18:53:13 These are only ever on the stack I hope? :)
dgozman 2016/08/19 20:50:12 Correct :-)
15 public: 15 public:
16 V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, const Stri ng16& humanReadableName) 16 V8ContextInfo(v8::Local<v8::Context> context, int contextGroupId, const Stri ngView& humanReadableName)
17 : context(context) 17 : context(context)
18 , contextGroupId(contextGroupId) 18 , contextGroupId(contextGroupId)
19 , humanReadableName(humanReadableName) 19 , humanReadableName(humanReadableName)
20 , hasMemoryOnConsole(false) 20 , hasMemoryOnConsole(false)
21 { 21 {
22 } 22 }
23 23
24 v8::Local<v8::Context> context; 24 v8::Local<v8::Context> context;
25 // Each v8::Context is a part of a group. The group id is used to find appro priate 25 // Each v8::Context is a part of a group. The group id is used to find appro priate
26 // V8DebuggerAgent to notify about events in the context. 26 // V8DebuggerAgent to notify about events in the context.
27 // |contextGroupId| must be non-0. 27 // |contextGroupId| must be non-0.
28 int contextGroupId; 28 int contextGroupId;
29 String16 humanReadableName; 29 StringView humanReadableName;
30 String16 origin; 30 StringView origin;
31 String16 auxData; 31 StringView auxData;
32 bool hasMemoryOnConsole; 32 bool hasMemoryOnConsole;
33 }; 33 };
34 34
35 } // namespace v8_inspector 35 } // namespace v8_inspector
36 36
37 #endif // V8ContextInfo_h 37 #endif // V8ContextInfo_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698