Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: styling Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8StackTraceImpl_h 5 #ifndef V8StackTraceImpl_h
6 #define V8StackTraceImpl_h 6 #define V8StackTraceImpl_h
7 7
8 #include "platform/inspector_protocol/InspectorProtocol.h" 8 #include "platform/inspector_protocol/InspectorProtocol.h"
9 #include "platform/v8_inspector/protocol/Runtime.h" 9 #include "platform/v8_inspector/protocol/Runtime.h"
10 #include "platform/v8_inspector/public/V8StackTrace.h" 10 #include "platform/v8_inspector/public/V8StackTrace.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 // This method drops the async chain. Use cloneImpl() instead. 58 // This method drops the async chain. Use cloneImpl() instead.
59 std::unique_ptr<V8StackTrace> clone() override; 59 std::unique_ptr<V8StackTrace> clone() override;
60 std::unique_ptr<V8StackTraceImpl> cloneImpl(); 60 std::unique_ptr<V8StackTraceImpl> cloneImpl();
61 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(V 8Debugger*) const; 61 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectForTail(V 8Debugger*) const;
62 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectImpl() co nst; 62 std::unique_ptr<protocol::Runtime::StackTrace> buildInspectorObjectImpl() co nst;
63 ~V8StackTraceImpl() override; 63 ~V8StackTraceImpl() override;
64 64
65 // V8StackTrace implementation. 65 // V8StackTrace implementation.
66 bool isEmpty() const override { return !m_frames.size(); }; 66 bool isEmpty() const override { return !m_frames.size(); };
67 String16 topSourceURL() const override; 67 StringView topSourceURL() const override;
68 int topLineNumber() const override; 68 int topLineNumber() const override;
69 int topColumnNumber() const override; 69 int topColumnNumber() const override;
70 String16 topScriptId() const override; 70 StringView topScriptId() const override;
71 String16 topFunctionName() const override; 71 StringView topFunctionName() const override;
72 std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject() c onst override; 72 std::unique_ptr<protocol::Runtime::API::StackTrace> buildInspectorObject() c onst override;
73 String16 toString() const override; 73 std::unique_ptr<StringBuffer> toString() const override;
74 74
75 private: 75 private:
76 V8StackTraceImpl(int contextGroupId, const String16& description, std::vecto r<Frame>& frames, std::unique_ptr<V8StackTraceImpl> parent); 76 V8StackTraceImpl(int contextGroupId, const String16& description, std::vecto r<Frame>& frames, std::unique_ptr<V8StackTraceImpl> parent);
77 77
78 int m_contextGroupId; 78 int m_contextGroupId;
79 String16 m_description; 79 String16 m_description;
80 std::vector<Frame> m_frames; 80 std::vector<Frame> m_frames;
81 std::unique_ptr<V8StackTraceImpl> m_parent; 81 std::unique_ptr<V8StackTraceImpl> m_parent;
82 }; 82 };
83 83
84 } // namespace v8_inspector 84 } // namespace v8_inspector
85 85
86 #endif // V8StackTraceImpl_h 86 #endif // V8StackTraceImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698