Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/public/StringView.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile on win Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Note: this include guard is very specific to not clash with wtf. Will be chan ged after moving out of blink.
6 #ifndef v8_inspector_public_StringView_h
7 #define v8_inspector_public_StringView_h
8
9 #include "platform/PlatformExport.h"
10
11 #include <cctype>
12 #include <stdint.h>
13
14 namespace v8_inspector {
15
16 class PLATFORM_EXPORT StringView {
17 public:
18 StringView() : m_is8Bit(true), m_length(0), m_characters8(nullptr) { }
esprehn 2016/08/26 04:55:48 We would normally wrap this to one var per line, s
dgozman 2016/08/26 18:50:52 Done.
19 StringView(const uint8_t* characters, unsigned length) : m_is8Bit(true), m_l ength(length), m_characters8(characters) { }
20 StringView(const uint16_t* characters, unsigned length) : m_is8Bit(false), m _length(length), m_characters16(characters) { }
21
22 bool is8Bit() const { return m_is8Bit; }
23 unsigned length() const { return m_length; }
24 // TODO(dgozman): add DCHECK(m_is8Bit) to accessors once platform can be use d here.
25 const uint8_t* characters8() const { return m_characters8; }
26 const uint16_t* characters16() const { return m_characters16; }
27
28 private:
29 bool m_is8Bit;
30 unsigned m_length;
31 union {
32 const uint8_t* m_characters8;
33 const uint16_t* m_characters16;
34 };
35 };
36
37 } // namespace v8_inspector
38
39 #endif // v8_inspector_public_StringView_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698