Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile on win Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 std::unique_ptr<protocol::Runtime::ExceptionDetails> exceptionDetails = protocol::Runtime::ExceptionDetails::create() 109 std::unique_ptr<protocol::Runtime::ExceptionDetails> exceptionDetails = protocol::Runtime::ExceptionDetails::create()
110 .setExceptionId(handler->m_inspector->nextExceptionId()) 110 .setExceptionId(handler->m_inspector->nextExceptionId())
111 .setText("Uncaught (in promise)") 111 .setText("Uncaught (in promise)")
112 .setLineNumber(stack && !stack->isEmpty() ? stack->topLineNumber() : 0) 112 .setLineNumber(stack && !stack->isEmpty() ? stack->topLineNumber() : 0)
113 .setColumnNumber(stack && !stack->isEmpty() ? stack->topColumnNumber () : 0) 113 .setColumnNumber(stack && !stack->isEmpty() ? stack->topColumnNumber () : 0)
114 .setException(handler->wrapObject(value)) 114 .setException(handler->wrapObject(value))
115 .build(); 115 .build();
116 if (stack) 116 if (stack)
117 exceptionDetails->setStackTrace(stack->buildInspectorObjectImpl()); 117 exceptionDetails->setStackTrace(stack->buildInspectorObjectImpl());
118 if (stack && !stack->isEmpty()) 118 if (stack && !stack->isEmpty())
119 exceptionDetails->setScriptId(stack->topScriptId()); 119 exceptionDetails->setScriptId(toString16(stack->topScriptId()));
120 handler->m_callback->sendSuccess(handler->wrapObject(value), std::move(e xceptionDetails)); 120 handler->m_callback->sendSuccess(handler->wrapObject(value), std::move(e xceptionDetails));
121 } 121 }
122 122
123 ProtocolPromiseHandler(V8InspectorImpl* inspector, int contextGroupId, int e xecutionContextId, const String16& objectGroup, bool returnByValue, bool generat ePreview, std::unique_ptr<Callback> callback) 123 ProtocolPromiseHandler(V8InspectorImpl* inspector, int contextGroupId, int e xecutionContextId, const String16& objectGroup, bool returnByValue, bool generat ePreview, std::unique_ptr<Callback> callback)
124 : m_inspector(inspector) 124 : m_inspector(inspector)
125 , m_contextGroupId(contextGroupId) 125 , m_contextGroupId(contextGroupId)
126 , m_executionContextId(executionContextId) 126 , m_executionContextId(executionContextId)
127 , m_objectGroup(objectGroup) 127 , m_objectGroup(objectGroup)
128 , m_returnByValue(returnByValue) 128 , m_returnByValue(returnByValue)
129 , m_generatePreview(generatePreview) 129 , m_generatePreview(generatePreview)
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 reportMessage(message, true); 678 reportMessage(message, true);
679 } 679 }
680 680
681 void V8RuntimeAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review) 681 void V8RuntimeAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review)
682 { 682 {
683 message->reportToFrontend(&m_frontend, m_session, generatePreview); 683 message->reportToFrontend(&m_frontend, m_session, generatePreview);
684 m_frontend.flush(); 684 m_frontend.flush();
685 } 685 }
686 686
687 } // namespace v8_inspector 687 } // namespace v8_inspector
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698