Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Side by Side Diff: third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Issue 2260233002: [DevTools] Migrate v8_inspector/public from String16 to String{View,Buffer}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: small fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ThreadDebugger_h 5 #ifndef ThreadDebugger_h
6 #define ThreadDebugger_h 6 #define ThreadDebugger_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/inspector/ConsoleTypes.h" 9 #include "core/inspector/ConsoleTypes.h"
10 #include "platform/Timer.h" 10 #include "platform/Timer.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::O bject>) override; 52 void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::O bject>) override;
53 void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, c onst char* name, v8::FunctionCallback, const char* description); 53 void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, c onst char* name, v8::FunctionCallback, const char* description);
54 static MessageLevel consoleAPITypeToMessageLevel(v8_inspector::V8ConsoleAPIT ype); 54 static MessageLevel consoleAPITypeToMessageLevel(v8_inspector::V8ConsoleAPIT ype);
55 55
56 v8::Isolate* m_isolate; 56 v8::Isolate* m_isolate;
57 57
58 private: 58 private:
59 // V8InspectorClient implementation. 59 // V8InspectorClient implementation.
60 void beginUserGesture() override; 60 void beginUserGesture() override;
61 void endUserGesture() override; 61 void endUserGesture() override;
62 String16 valueSubtype(v8::Local<v8::Value>) override; 62 std::unique_ptr<v8_inspector::StringBuffer> valueSubtype(v8::Local<v8::Value >) override;
63 bool formatAccessorsAsProperties(v8::Local<v8::Value>) override; 63 bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
64 double currentTimeMS() override; 64 double currentTimeMS() override;
65 bool isInspectableHeapObject(v8::Local<v8::Object>) override; 65 bool isInspectableHeapObject(v8::Local<v8::Object>) override;
66 void consoleTime(const String16& title) override; 66 void consoleTime(const v8_inspector::StringView& title) override;
67 void consoleTimeEnd(const String16& title) override; 67 void consoleTimeEnd(const v8_inspector::StringView& title) override;
68 void consoleTimeStamp(const String16& title) override; 68 void consoleTimeStamp(const v8_inspector::StringView& title) override;
69 void startRepeatingTimer(double, v8_inspector::V8InspectorClient::TimerCallb ack, void* data) override; 69 void startRepeatingTimer(double, v8_inspector::V8InspectorClient::TimerCallb ack, void* data) override;
70 void cancelTimer(void* data) override; 70 void cancelTimer(void* data) override;
71 71
72 void onTimer(TimerBase*); 72 void onTimer(TimerBase*);
73 73
74 static void setMonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Valu e>&, bool enabled); 74 static void setMonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Valu e>&, bool enabled);
75 static void monitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& ); 75 static void monitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& );
76 static void unmonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value >&); 76 static void unmonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value >&);
77 77
78 static void getEventListenersCallback(const v8::FunctionCallbackInfo<v8::Val ue>&); 78 static void getEventListenersCallback(const v8::FunctionCallbackInfo<v8::Val ue>&);
79 79
80 std::unique_ptr<v8_inspector::V8Inspector> m_v8Inspector; 80 std::unique_ptr<v8_inspector::V8Inspector> m_v8Inspector;
81 Vector<std::unique_ptr<Timer<ThreadDebugger>>> m_timers; 81 Vector<std::unique_ptr<Timer<ThreadDebugger>>> m_timers;
82 Vector<v8_inspector::V8InspectorClient::TimerCallback> m_timerCallbacks; 82 Vector<v8_inspector::V8InspectorClient::TimerCallback> m_timerCallbacks;
83 Vector<void*> m_timerData; 83 Vector<void*> m_timerData;
84 std::unique_ptr<UserGestureIndicator> m_userGestureIndicator; 84 std::unique_ptr<UserGestureIndicator> m_userGestureIndicator;
85 }; 85 };
86 86
87 } // namespace blink 87 } // namespace blink
88 88
89 #endif // ThreadDebugger_h 89 #endif // ThreadDebugger_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698