chrome/browser/download/download_crx_util.cc - Issue 226023003: Create CrxInstaller directly in WebstoreInstaller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_crx_util.cc

Issue 226023003: Create CrxInstaller directly in WebstoreInstaller (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_crx_util.cc

diff --git a/chrome/browser/download/download_crx_util.cc b/chrome/browser/download/download_crx_util.cc

index bea0aaa11497c844291c218286ce44bcc78932ae..8c260249de36135d68fcd1442d0e91c466a2e30b 100644

--- a/chrome/browser/download/download_crx_util.cc

+++ b/chrome/browser/download/download_crx_util.cc

@@ -102,10 +102,9 @@ scoped_refptr<extensions::CrxInstaller> OpenChromeExtension(

WebstoreInstaller::GetAssociatedApproval(download_item) != NULL;

installer->set_original_mime_type(download_item.GetOriginalMimeType());

installer->set_apps_require_extension_mime_type(true);

- installer->set_download_url(download_item.GetURL());

installer->set_is_gallery_install(is_gallery_download);

if (is_gallery_download)

- installer->set_original_download_url(download_item.GetOriginalUrl());

+ installer->set_download_id(download_item.GetId());

installer->set_allow_silent_install(is_gallery_download);

installer->InstallCrx(download_item.GetFullPath());

}