Add SSA instructions for reified type information

Add SSA instructions for reified type information

This enables GVN optimizations of type representations, e.g.

        var touches, targetTouches, changedTouches, mockTouchList, t1;
        touches = H.setRuntimeTypeInfo([], [W.Touch]);
        targetTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        changedTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], [W.Touch]);
--->
        var t1, touches, targetTouches, changedTouches, mockTouchList;
        t1 = [W.Touch];
        touches = H.setRuntimeTypeInfo([], t1);
        targetTouches = H.setRuntimeTypeInfo([], t1);
        changedTouches = H.setRuntimeTypeInfo([], t1);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], t1);

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/266ac1b0bc68763868f1aa448f5c8b2f822fc7ad

[sra1, 2016-08-19 17:42:53]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-08-19 18:21:46]

lgtm - I mostly have questions to help me understand.

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:6816: return
callSetRuntimeTypeInfoWithTypeArguments(type.element, arguments, object);
nit: dartfmt

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
pkg/compiler/lib/src/ssa/codegen.dart:2861: push(js.js(r'#.$builtinTypeInfo',
receiver));
I thought $builtinTypeInfo was replaced by $ti, is it still around in some
cases? or is it just that the other CL is not submitted yet, but after that this
will become $ti?

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
pkg/compiler/lib/src/ssa/codegen.dart:2877: new
StaticUse.staticInvoke(helperElement, CallStructure.THREE_ARGS));
I'm surprised we never registered this before (even though it was called from
the builder), was that a bug?

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
pkg/compiler/lib/src/ssa/codegen.dart:2906: print('$node   $index 
${node.inputs}');
delete debug code?

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3251: /// - INSTANCE: A headless flat form
for representing the sequence of values of
I'm trying to understand the need for the distinction between COMPLETE and
INSTANCE. When do we expect to use each? Would you say that INSTANCE is only
used to specify the rti when calling a constructor (new Foo(), [] literals),
while the COMPLETE is used for nested type arguments that are given to the
INSTANCE type?

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3255: /// variables with consecutive values
from [arguments], in the order generated
[arguments] => [inputs]?

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3261: /// The INSTANCE form is constructed
as a list of [arguments]. This is the same
ditto?

[sra1, 2016-08-19 18:47:44]

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder.dart (right):

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder.dart:6816: return
callSetRuntimeTypeInfoWithTypeArguments(type.element, arguments, object);
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> nit: dartfmt

I will.

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
pkg/compiler/lib/src/ssa/codegen.dart:2861: push(js.js(r'#.$builtinTypeInfo',
receiver));
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> I thought $builtinTypeInfo was replaced by $ti, is it still around in some
> cases? or is it just that the other CL is not submitted yet, but after that
this
> will become $ti?

Yes, the renaming is part of the other CL

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
pkg/compiler/lib/src/ssa/codegen.dart:2877: new
StaticUse.staticInvoke(helperElement, CallStructure.THREE_ARGS));
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> I'm surprised we never registered this before (even though it was called from
> the builder), was that a bug?

No bug. It was registered via being lowered to a HInvokeStatic.

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/co...
pkg/compiler/lib/src/ssa/codegen.dart:2906: print('$node   $index 
${node.inputs}');
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> delete debug code?

Done. That was from debugging https://codereview.chromium.org/2257813003/

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3251: /// - INSTANCE: A headless flat form
for representing the sequence of values of
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> I'm trying to understand the need for the distinction between COMPLETE and
> INSTANCE. When do we expect to use each? Would you say that INSTANCE is only
> used to specify the rti when calling a constructor (new Foo(), [] literals),
> while the COMPLETE is used for nested type arguments that are given to the
> INSTANCE type?

Correct.
This is just how it is currently done.
I hope to simplify this later.

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3255: /// variables with consecutive values
from [arguments], in the order generated
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> [arguments] => [inputs]?

Done.

https://codereview.chromium.org/2260223002/diff/1/pkg/compiler/lib/src/ssa/no...
pkg/compiler/lib/src/ssa/nodes.dart:3261: /// The INSTANCE form is constructed
as a list of [arguments]. This is the same
On 2016/08/19 18:21:46, Siggi Cherem (dart-lang) wrote:
> ditto?

Done.

[sra1, 2016-08-19 20:02:29]

Description was changed from

==========
Add SSA instructions for reified type information

This enables GVN optimizations of type representations, e.g.

        var touches, targetTouches, changedTouches, mockTouchList, t1;
        touches = H.setRuntimeTypeInfo([], [W.Touch]);
        targetTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        changedTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], [W.Touch]);
--->
        var t1, touches, targetTouches, changedTouches, mockTouchList;
        t1 = [W.Touch];
        touches = H.setRuntimeTypeInfo([], t1);
        targetTouches = H.setRuntimeTypeInfo([], t1);
        changedTouches = H.setRuntimeTypeInfo([], t1);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], t1);

BUG=
==========

to

==========
Add SSA instructions for reified type information

This enables GVN optimizations of type representations, e.g.

        var touches, targetTouches, changedTouches, mockTouchList, t1;
        touches = H.setRuntimeTypeInfo([], [W.Touch]);
        targetTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        changedTouches = H.setRuntimeTypeInfo([], [W.Touch]);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], [W.Touch]);
--->
        var t1, touches, targetTouches, changedTouches, mockTouchList;
        t1 = [W.Touch];
        touches = H.setRuntimeTypeInfo([], t1);
        targetTouches = H.setRuntimeTypeInfo([], t1);
        changedTouches = H.setRuntimeTypeInfo([], t1);
        mockTouchList = H.setRuntimeTypeInfo([new S.MockTouch(e)], t1);

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/266ac1b0bc68763868f1aa448f5c8b2f822fc7ad
==========

[sra1, 2016-08-19 20:02:30]

Committed patchset #3 (id:40001) manually as
266ac1b0bc68763868f1aa448f5c8b2f822fc7ad (presubmit successful).