Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2260213002: Removed Cardboard SDK from third_party (Closed)

Created:
4 years, 4 months ago by bajones
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gvr_webvr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed Cardboard SDK from third_party All dependencies on the Cardboard SDK have been removed replaced by the GoogleVR SDK, so this library can now be removed entirely. BUG=389343 Committed: https://crrev.com/b15b30e03653c5a97466f8de1433e07e95b6bb36 Cr-Commit-Position: refs/heads/master@{#413294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -249 lines) Patch
M DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/cardboard-java/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/cardboard-java/LICENSE View 1 chunk +0 lines, -190 lines 0 comments Download
D third_party/cardboard-java/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/cardboard-java/README.chromium View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/cardboard-java/cardboard.gyp View 1 chunk +0 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (9 generated)
bajones
girard@: Quick review on this one? Just need a rubber stamp, I doubt anyone will ...
4 years, 4 months ago (2016-08-19 17:43:08 UTC) #2
girard
On 2016/08/19 17:43:08, bajones wrote: > girard@: Quick review on this one? Just need a ...
4 years, 4 months ago (2016-08-19 18:11:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260213002/1
4 years, 4 months ago (2016-08-19 21:06:03 UTC) #5
Ken Russell (switch to Gerrit)
lgtm
4 years, 4 months ago (2016-08-19 21:12:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/242207)
4 years, 4 months ago (2016-08-19 21:15:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260213002/1
4 years, 4 months ago (2016-08-19 21:22:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/242227)
4 years, 4 months ago (2016-08-19 21:33:30 UTC) #13
bajones
sky@ or dglazkov@: I guess being an owner of a third_party directory does not grant ...
4 years, 4 months ago (2016-08-19 22:09:06 UTC) #15
sky
LGTM
4 years, 4 months ago (2016-08-19 22:32:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260213002/1
4 years, 4 months ago (2016-08-19 22:36:32 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 00:34:15 UTC) #19
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:36:13 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b15b30e03653c5a97466f8de1433e07e95b6bb36
Cr-Commit-Position: refs/heads/master@{#413294}

Powered by Google App Engine
This is Rietveld 408576698