Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: ui/file_manager/externs/volume_info.js

Issue 2260133002: Files: Extract VolumeInfo interface from volume_manager.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/externs/volume_info.js
diff --git a/ui/file_manager/externs/volume_info.js b/ui/file_manager/externs/volume_info.js
new file mode 100644
index 0000000000000000000000000000000000000000..620842512676a840340ed3ae3ddd9e5f1dcabfb1
--- /dev/null
+++ b/ui/file_manager/externs/volume_info.js
@@ -0,0 +1,65 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+/**
+ * @interface
oka 2016/08/21 22:15:37 Please add comments. You can move comments from Vo
fukino 2016/08/22 05:32:48 Done.
+ */
+function VolumeInfo() {};
+
+/** @type {VolumeManagerCommon.VolumeType} */
+VolumeInfo.prototype.volumeType;
+
+/** @type {string} */
+VolumeInfo.prototype.volumeId;
oka 2016/08/22 01:58:06 Could you elabolate what is this for? Add example
fukino 2016/08/22 05:32:47 I annotated it as just "The ID of the volume.", si
oka 2016/08/22 06:51:09 Acknowledged. You could remove the comment then.
fukino 2016/08/22 08:50:57 Thanks! Removed.
+
+/** @type {FileSystem} */
+VolumeInfo.prototype.fileSystem;
+
+/** @type {DirectoryEntry} */
+VolumeInfo.prototype.displayRoot;
oka 2016/08/22 01:58:07 Move comments from VolumeInfoImpl.
fukino 2016/08/22 05:32:47 Done.
+
+/** @type {Object<!FakeEntry>}} */
+VolumeInfo.prototype.fakeEntries;
oka 2016/08/22 01:58:07 Add a comment; what is this for?
fukino 2016/08/22 05:32:47 Done.
+
+/** @type {(string|undefined)} */
+VolumeInfo.prototype.error;
oka 2016/08/22 01:58:07 Add comment.
fukino 2016/08/22 05:32:48 Done.
+
+/** @type {(string|undefined)} */
+VolumeInfo.prototype.deviceType;
oka 2016/08/22 01:58:06 Add comment.
fukino 2016/08/22 05:32:48 Done.
+
+/** @type {(string|undefined)} */
+VolumeInfo.prototype.devicePath;
oka 2016/08/22 01:58:07 Add comment.
fukino 2016/08/22 05:32:47 Done.
+
+/** @type {boolean} */
+VolumeInfo.prototype.isReadOnly;
+
+/** @type {!{displayName:string, isCurrentProfile:boolean}} */
+VolumeInfo.prototype.profile;
oka 2016/08/22 01:58:07 Could you add an example of |displayName|?
fukino 2016/08/22 05:32:48 foobar@chromium.org. However, let me describe the
oka 2016/08/22 06:51:09 Acknowledged.
+
+/** @type {string} */
+VolumeInfo.prototype.label;
oka 2016/08/22 01:58:06 Could you add an example of |label|?
fukino 2016/08/22 05:32:47 Done.
+
+/** @type {(string|undefined)} */
+VolumeInfo.prototype.extensionId;
+
+/** @type {boolean} */
+VolumeInfo.prototype.hasMedia;
+
+/** @type {boolean} */
+VolumeInfo.prototype.configurable;
+
+/** @type {boolean} */
+VolumeInfo.prototype.watchable;
+
+/** @type {VolumeManagerCommon.Source} */
+VolumeInfo.prototype.source;
+
+/**
+ * @param {function(!DirectoryEntry)=} opt_onSuccess Success callback with the
+ * display root directory as an argument.
+ * @param {function(*)=} opt_onFailure Failure callback.
+ * @return {!Promise.<!DirectoryEntry>}
+ */
+VolumeInfo.prototype.resolveDisplayRoot = function(
+ opt_onSuccess, opt_onFailure) {};

Powered by Google App Engine
This is Rietveld 408576698