Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 // Copyright 2016 The Chromium Authors. All rights reserved. | |
| 2 // Use of this source code is governed by a BSD-style license that can be | |
| 3 // found in the LICENSE file. | |
| 4 | |
| 5 /** | |
| 6 * @interface | |
|
oka
2016/08/21 22:15:37
Please add comments. You can move comments from Vo
fukino
2016/08/22 05:32:48
Done.
| |
| 7 */ | |
| 8 function VolumeInfo() {}; | |
| 9 | |
| 10 /** @type {VolumeManagerCommon.VolumeType} */ | |
| 11 VolumeInfo.prototype.volumeType; | |
| 12 | |
| 13 /** @type {string} */ | |
| 14 VolumeInfo.prototype.volumeId; | |
|
oka
2016/08/22 01:58:06
Could you elabolate what is this for? Add example
fukino
2016/08/22 05:32:47
I annotated it as just "The ID of the volume.", si
oka
2016/08/22 06:51:09
Acknowledged. You could remove the comment then.
fukino
2016/08/22 08:50:57
Thanks! Removed.
| |
| 15 | |
| 16 /** @type {FileSystem} */ | |
| 17 VolumeInfo.prototype.fileSystem; | |
| 18 | |
| 19 /** @type {DirectoryEntry} */ | |
| 20 VolumeInfo.prototype.displayRoot; | |
|
oka
2016/08/22 01:58:07
Move comments from VolumeInfoImpl.
fukino
2016/08/22 05:32:47
Done.
| |
| 21 | |
| 22 /** @type {Object<!FakeEntry>}} */ | |
| 23 VolumeInfo.prototype.fakeEntries; | |
|
oka
2016/08/22 01:58:07
Add a comment; what is this for?
fukino
2016/08/22 05:32:47
Done.
| |
| 24 | |
| 25 /** @type {(string|undefined)} */ | |
| 26 VolumeInfo.prototype.error; | |
|
oka
2016/08/22 01:58:07
Add comment.
fukino
2016/08/22 05:32:48
Done.
| |
| 27 | |
| 28 /** @type {(string|undefined)} */ | |
| 29 VolumeInfo.prototype.deviceType; | |
|
oka
2016/08/22 01:58:06
Add comment.
fukino
2016/08/22 05:32:48
Done.
| |
| 30 | |
| 31 /** @type {(string|undefined)} */ | |
| 32 VolumeInfo.prototype.devicePath; | |
|
oka
2016/08/22 01:58:07
Add comment.
fukino
2016/08/22 05:32:47
Done.
| |
| 33 | |
| 34 /** @type {boolean} */ | |
| 35 VolumeInfo.prototype.isReadOnly; | |
| 36 | |
| 37 /** @type {!{displayName:string, isCurrentProfile:boolean}} */ | |
| 38 VolumeInfo.prototype.profile; | |
|
oka
2016/08/22 01:58:07
Could you add an example of |displayName|?
fukino
2016/08/22 05:32:48
foobar@chromium.org. However, let me describe the
oka
2016/08/22 06:51:09
Acknowledged.
| |
| 39 | |
| 40 /** @type {string} */ | |
| 41 VolumeInfo.prototype.label; | |
|
oka
2016/08/22 01:58:06
Could you add an example of |label|?
fukino
2016/08/22 05:32:47
Done.
| |
| 42 | |
| 43 /** @type {(string|undefined)} */ | |
| 44 VolumeInfo.prototype.extensionId; | |
| 45 | |
| 46 /** @type {boolean} */ | |
| 47 VolumeInfo.prototype.hasMedia; | |
| 48 | |
| 49 /** @type {boolean} */ | |
| 50 VolumeInfo.prototype.configurable; | |
| 51 | |
| 52 /** @type {boolean} */ | |
| 53 VolumeInfo.prototype.watchable; | |
| 54 | |
| 55 /** @type {VolumeManagerCommon.Source} */ | |
| 56 VolumeInfo.prototype.source; | |
| 57 | |
| 58 /** | |
| 59 * @param {function(!DirectoryEntry)=} opt_onSuccess Success callback with the | |
| 60 * display root directory as an argument. | |
| 61 * @param {function(*)=} opt_onFailure Failure callback. | |
| 62 * @return {!Promise.<!DirectoryEntry>} | |
| 63 */ | |
| 64 VolumeInfo.prototype.resolveDisplayRoot = function( | |
| 65 opt_onSuccess, opt_onFailure) {}; | |
| OLD | NEW |