Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.h

Issue 2260113002: Lazily install origin trial features on V8 objects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase after parent CL landed Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
index 57581c7d9c143c85c9848bed4f4da2c059c854cf..ea1f70e1ed1b5490999ac6f675d9dfe1c26e6aee 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
@@ -69,8 +69,6 @@ class WorkerGlobalScope;
class WorkerOrWorkletGlobalScope;
class XPathNSResolver;
-using InstallOriginTrialsFunction = void (*)(ScriptState*);
-
template <typename T>
struct V8TypeOf {
STATIC_ONLY(V8TypeOf);
@@ -930,20 +928,6 @@ VectorType toImplSequence(v8::Isolate* isolate, v8::Local<v8::Value> value, Exce
return result;
}
-// Installs all of the origin-trial-enabled V8 bindings for the given context
-// and world, based on the trial tokens which have been added to the
-// ExecutionContext. This should be called after the V8 context has been
-// installed, but may be called multiple times, as trial tokens are
-// encountered. It indirectly calls the function set by
-// |setInstallOriginTrialsFunction|.
-CORE_EXPORT void installOriginTrials(ScriptState*);
-
-// Sets the function to be called by |installOriginTrials|. The function is
-// initially set to the private |installOriginTrialsForCore| function, but
-// can be overridden by this function. A pointer to the previously set function
-// is returned, so that functions can be chained.
-CORE_EXPORT InstallOriginTrialsFunction setInstallOriginTrialsFunction(InstallOriginTrialsFunction);
-
// If the current context causes out of memory, JavaScript setting
// is disabled and it returns true.
bool handleOutOfMemory();

Powered by Google App Engine
This is Rietveld 408576698