Issue 22601007: Adjust wifi toggle message layout to avoid the wrapping of the message.

Issue 22601007: Adjust wifi toggle message layout to avoid the wrapping of the message. (Closed)

Created:
7 years, 4 months ago by jennyz

Modified:
7 years, 4 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, sadrul, ben+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adjust wifi toggle message layout to avoid the wrapping of the message too shortly. BUG=263984 R=stevenjb@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217029

Patch Set 2 : fit nit. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	ash/system/chromeos/network/tray_network.cc	View	1	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

stevenjb

lgtm w/ WS fix https://codereview.chromium.org/22601007/diff/1/ash/system/chromeos/network/tray_network.cc File ash/system/chromeos/network/tray_network.cc (right): https://codereview.chromium.org/22601007/diff/1/ash/system/chromeos/network/tray_network.cc#newcode271 ash/system/chromeos/network/tray_network.cc:271: label_view_->SetY((height()-label_view_->GetPreferredSize().height())/2); ' ' around '-' ...

7 years, 4 months ago (2013-08-09 23:54:47 UTC) #3

jennyz

https://codereview.chromium.org/22601007/diff/1/ash/system/chromeos/network/tray_network.cc File ash/system/chromeos/network/tray_network.cc (right): https://codereview.chromium.org/22601007/diff/1/ash/system/chromeos/network/tray_network.cc#newcode271 ash/system/chromeos/network/tray_network.cc:271: label_view_->SetY((height()-label_view_->GetPreferredSize().height())/2); On 2013/08/09 23:54:47, stevenjb (chromium) wrote: > ' ...

7 years, 4 months ago (2013-08-10 00:13:57 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/22601007/7001

7 years, 4 months ago (2013-08-10 00:16:21 UTC) #5

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 4 months ago (2013-08-10 00:33:46 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/22601007/7001

7 years, 4 months ago (2013-08-12 16:21:45 UTC) #7

jennyz

7 years, 4 months ago (2013-08-12 17:42:45 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 manually as r217029 (presubmit successful).

Expand Messages | Collapse Messages