Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2260053003: Rename compare_build_artifacts directory name. (Closed)

Created:
4 years, 4 months ago by Yoshisato Yanagisawa
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename compare_build_artifacts directory name. Since deterministic_build_blacklist.json is used by not only compare_build_artifacts.py but also remove_build_metadata.py, let me rename the directory name to determinism to reflect what this is. BUG=314403 Committed: https://crrev.com/32d5b679526857c915264c517ae3334421bb2be7 Cr-Commit-Position: refs/heads/master@{#413398}

Patch Set 1 #

Patch Set 2 : rename direname #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-2 lines, -603 lines) Patch
D tools/compare_build_artifacts/compare_build_artifacts.py View 1 chunk +0 lines, -596 lines 0 comments Download
D tools/compare_build_artifacts/deterministic_build_blacklist.json View 1 chunk +0 lines, -9 lines 0 comments Download
A + tools/determinism/compare_build_artifacts.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools/determinism/deterministic_build_blacklist.json View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Yoshisato Yanagisawa
Sorry for going back and forward but I found other python code in isolate recipe_module ...
4 years, 4 months ago (2016-08-19 02:22:13 UTC) #2
M-A Ruel
it's about build determinism, not about isolate. So you could name the directory 'determinism' (?) ...
4 years, 4 months ago (2016-08-19 20:23:18 UTC) #3
Dirk Pranke
I defer to maruel here. lgtm if/when he's happy.
4 years, 4 months ago (2016-08-19 20:29:06 UTC) #5
Yoshisato Yanagisawa
I have renamed the directory name.
4 years, 4 months ago (2016-08-22 02:24:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260053003/20001
4 years, 4 months ago (2016-08-22 02:45:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 03:29:48 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 03:32:14 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/32d5b679526857c915264c517ae3334421bb2be7
Cr-Commit-Position: refs/heads/master@{#413398}

Powered by Google App Engine
This is Rietveld 408576698