Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: src/IceInstMIPS32.h

Issue 2259983004: [SubZero] Generate ELF output for MIPS (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Address review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceInstMIPS32.h
diff --git a/src/IceInstMIPS32.h b/src/IceInstMIPS32.h
index 5dc836713db774ea7a2f25b74f08b2c6af2a1425..67cac111dff71130dbf722e4265c6983181e60bb 100644
--- a/src/IceInstMIPS32.h
+++ b/src/IceInstMIPS32.h
@@ -1,11 +1,11 @@
-//===- subzero/src/IceInstMIPS32.h - MIPS32 machine instrs --*- C++ -*-=== //
+//===- subzero/src/IceInstMIPS32.h - MIPS32 machine instrs --*- C++ -*-======//
Jim Stichnoth 2016/08/24 15:37:39 Add extra '-' characters for padding instead of '=
jaydeep.patil 2016/08/25 04:39:08 Done.
//
// The Subzero Code Generator
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
-//===----------------------------------------------------------------------===//
+//===---------------------------------------------------------------------===//
///
/// \file
/// \brief Declares the InstMIPS32 and OperandMIPS32 classes and their
@@ -14,7 +14,7 @@
/// This represents the machine instructions and operands used for MIPS32 code
/// selection.
///
-//===----------------------------------------------------------------------===//
+//===---------------------------------------------------------------------===//
#ifndef SUBZERO_SRC_ICEINSTMIPS32_H
#define SUBZERO_SRC_ICEINSTMIPS32_H
@@ -199,6 +199,8 @@ public:
Xori
};
+ static constexpr size_t InstSize = sizeof(uint32_t);
+
static const char *getWidthString(Type Ty);
void dump(const Cfg *Func) const override;
@@ -675,7 +677,7 @@ public:
}
bool repointEdges(CfgNode *OldNode, CfgNode *NewNode) override;
void emit(const Cfg *Func) const override;
- void emitIAS(const Cfg *Func) const override { (void)Func; };
+ void emitIAS(const Cfg *Func) const override;
void dump(const Cfg *Func) const override;
static bool classof(const Inst *Instr) { return isClassof(Instr, Br); }
@@ -751,7 +753,6 @@ public:
Str << (int32_t)Imm;
else
Str << Imm;
- Str << "\n";
}
void emitIAS(const Cfg *Func) const override {
@@ -771,7 +772,6 @@ public:
Str << (int32_t)Imm;
else
Str << Imm;
- Str << "\n";
}
static bool classof(const Inst *Inst) { return isClassof(Inst, K); }

Powered by Google App Engine
This is Rietveld 408576698