Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2259983002: Pending input event count can get thrown off by coalesced events. (Closed)

Created:
4 years, 4 months ago by dtapuska
Modified:
4 years, 4 months ago
Reviewers:
tdresser, Sami
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pending input event count can get thrown off by coalesced events. When the main thread event queue coalesces multiple events the count inside the render scheduler can be throw off. Ensure that for every coalesced event we let the render scheduler know it was handled. BUG=637640 Committed: https://crrev.com/73d217001f42b22ce119e5269e74e1f6923d80ee Cr-Commit-Position: refs/heads/master@{#412968}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add brackets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M content/renderer/input/main_thread_event_queue.cc View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
dtapuska
4 years, 4 months ago (2016-08-18 20:53:23 UTC) #5
tdresser
LGTM, but get a test in place tomorrow. https://codereview.chromium.org/2259983002/diff/1/content/renderer/input/main_thread_event_queue.cc File content/renderer/input/main_thread_event_queue.cc (right): https://codereview.chromium.org/2259983002/diff/1/content/renderer/input/main_thread_event_queue.cc#newcode125 content/renderer/input/main_thread_event_queue.cc:125: if ...
4 years, 4 months ago (2016-08-18 20:58:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259983002/20001
4 years, 4 months ago (2016-08-18 21:02:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 23:18:56 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/73d217001f42b22ce119e5269e74e1f6923d80ee Cr-Commit-Position: refs/heads/master@{#412968}
4 years, 4 months ago (2016-08-18 23:24:47 UTC) #13
Sami
4 years, 4 months ago (2016-08-19 14:50:33 UTC) #14
Message was sent while issue was closed.
lgtm, thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698