Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7150)

Unified Diff: chrome/test/data/extensions/api_test/users_private/test.js

Issue 2259943003: Settings People CrOS: Display supervised users' names correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test variables Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/users_private/test.js
diff --git a/chrome/test/data/extensions/api_test/users_private/test.js b/chrome/test/data/extensions/api_test/users_private/test.js
index 62832e472c52fe8abfc537dff84d64a412191749..843fc08dd3732b6620864ac3984cc481f41cd2db 100644
--- a/chrome/test/data/extensions/api_test/users_private/test.js
+++ b/chrome/test/data/extensions/api_test/users_private/test.js
@@ -15,6 +15,8 @@ function callbackResult(result) {
var kEmail1 = 'asdf@gmail.com';
var kEmail2 = 'asdf2@gmail.com';
+var kName1 = kEmail1;
Devlin 2016/08/20 01:23:04 it'd probably be good to make this something diffe
tommycli 2016/08/20 01:35:57 So... they would only be different for locally man
+var kName2 = kEmail2;
var availableTests = [
function addUser() {
@@ -26,7 +28,7 @@ var availableTests = [
chrome.usersPrivate.getWhitelistedUsers(function(users) {
var foundUser = false;
users.forEach(function(user) {
- if (user.email == kEmail1) {
+ if (user.email == kEmail1 && user.name == kName1) {
foundUser = true;
}
});
@@ -54,8 +56,8 @@ var availableTests = [
chrome.usersPrivate.getWhitelistedUsers(
function(users) {
chrome.test.assertTrue(users.length == 1);
- chrome.test.assertEq(
- kEmail2, users[0].email);
+ chrome.test.assertEq(kEmail2, users[0].email);
+ chrome.test.assertEq(kName2, users[0].name);
chrome.test.succeed();
});
@@ -78,4 +80,3 @@ var testToRun = window.location.search.substring(1);
chrome.test.runTests(availableTests.filter(function(op) {
return op.name == testToRun;
}));
-
« no previous file with comments | « chrome/common/extensions/api/users_private.idl ('k') | third_party/closure_compiler/externs/users_private.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698