Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/test/data/extensions/api_test/users_private/test.js

Issue 2259943003: Settings People CrOS: Display supervised users' names correctly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix closure compile Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/users_private/test.js
diff --git a/chrome/test/data/extensions/api_test/users_private/test.js b/chrome/test/data/extensions/api_test/users_private/test.js
index 62832e472c52fe8abfc537dff84d64a412191749..96e571314ed0e19c7f4d9054ccd365ff3ee6afc1 100644
--- a/chrome/test/data/extensions/api_test/users_private/test.js
+++ b/chrome/test/data/extensions/api_test/users_private/test.js
@@ -26,7 +26,7 @@ var availableTests = [
chrome.usersPrivate.getWhitelistedUsers(function(users) {
var foundUser = false;
users.forEach(function(user) {
- if (user.email == kEmail1) {
+ if (user.email == kEmail1 && user.name == kEmail1) {
Oren Blasberg 2016/08/19 18:47:48 I think you're reusing the kEmail1 variable for us
tommycli 2016/08/19 19:15:58 Done.
foundUser = true;
}
});
@@ -54,8 +54,8 @@ var availableTests = [
chrome.usersPrivate.getWhitelistedUsers(
function(users) {
chrome.test.assertTrue(users.length == 1);
- chrome.test.assertEq(
- kEmail2, users[0].email);
+ chrome.test.assertEq(kEmail2, users[0].email);
+ chrome.test.assertEq(kEmail2, users[0].name);
Oren Blasberg 2016/08/19 18:47:48 So this would be kName2
tommycli 2016/08/19 19:15:58 Done.
chrome.test.succeed();
});
@@ -78,4 +78,3 @@ var testToRun = window.location.search.substring(1);
chrome.test.runTests(availableTests.filter(function(op) {
return op.name == testToRun;
}));
-
« no previous file with comments | « chrome/common/extensions/api/users_private.idl ('k') | third_party/closure_compiler/externs/users_private.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698