Settings People CrOS: Display supervised users' names correctly.

chrome/test/data/extensions/api_test/users_private/test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This just tests the interface. It does not test for specific results, only
 // that callbacks are correctly invoked, expected parameters are correct,
 // and failures are detected.
 
 function callbackResult(result) {
   if (chrome.runtime.lastError)
     chrome.test.fail(chrome.runtime.lastError.message);
   else if (result == false)
     chrome.test.fail('Failed: ' + result);
 }
 
 var kEmail1 = 'asdf@gmail.com';
 var kEmail2 = 'asdf2@gmail.com';
 
 var availableTests = [
   function addUser() {
     chrome.usersPrivate.addWhitelistedUser(
         kEmail1,
         function(result) {
           callbackResult(result);
 
           chrome.usersPrivate.getWhitelistedUsers(function(users) {
             var foundUser = false;
             users.forEach(function(user) {
-              if (user.email == kEmail1) {
+              if (user.email == kEmail1 && user.name == kEmail1) {

[Oren Blasberg, 2016/08/19 18:47:48]

I think you're reusing the kEmail1 variable for user.name, but this makes the
test a bit confusing (I thought it was a mistake until I thought about it a bit
more). Please make a new "kName1" variable and just use that here and in the
test below instead.

[tommycli, 2016/08/19 19:15:58]

Done.

                 foundUser = true;
               }
             });
             chrome.test.assertTrue(foundUser);
             chrome.test.succeed();
           });
         });
   },
 
   function addAndRemoveUsers() {
     chrome.usersPrivate.addWhitelistedUser(
         kEmail1,
         function(result1) {
           callbackResult(result1);
 
           chrome.usersPrivate.addWhitelistedUser(
               kEmail2,
               function(result2) {
                 callbackResult(result2);
 
                   chrome.usersPrivate.removeWhitelistedUser(
                       kEmail1,
                       function(result3) {
 
                         chrome.usersPrivate.getWhitelistedUsers(
                             function(users) {
                               chrome.test.assertTrue(users.length == 1);
-                              chrome.test.assertEq(
-                                  kEmail2, users[0].email);
+                              chrome.test.assertEq(kEmail2, users[0].email);
+                              chrome.test.assertEq(kEmail2, users[0].name);

[Oren Blasberg, 2016/08/19 18:47:48]

So this would be kName2

[tommycli, 2016/08/19 19:15:58]

Done.

                               chrome.test.succeed();
                             });
 
                       });
               });
         });
 
   },
 
   function isOwner() {
     chrome.usersPrivate.isCurrentUserOwner(function(isOwner) {
       // Since we are testing with --stub-cros-settings this should be true.
       chrome.test.assertTrue(isOwner);
       chrome.test.succeed();
     });
   },
 ];
 
 var testToRun = window.location.search.substring(1);
 chrome.test.runTests(availableTests.filter(function(op) {
   return op.name == testToRun;
 }));
-