Blink-side layout tests for the new Device Orientation API.

Blink-side layout tests for the new Device Orientation API.

Implement the Blink-side testing framework for the new
Device Orientation API, using Platform instead of the old
'client' approach.
In particular this patch:
- Adds checks for the 'absolute' field.
- Modifies Layout tests where necessary to ensure they are
working correctly.
- Switches to the NewDeviceOrientationController
in DOMWindow.

BUG=261165
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158028

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158454

[abarth-chromium, 2013-08-08 17:54:31]

LGTM.  Thanks!

[commit-bot: I haz the power, 2013-08-08 17:56:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22599005/1

[commit-bot: I haz the power, 2013-08-08 19:11:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-19 09:35:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22599005/34001

[commit-bot: I haz the power, 2013-09-19 09:35:35]

Failed to apply patch for Source/core/page/DOMWindow.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/DOMWindow.cpp
  Hunk #2 succeeded at 94 (offset 1 line).
  Hunk #3 succeeded at 434 (offset 1 line).
  Hunk #4 succeeded at 1430 (offset -1 lines).
  Hunk #5 succeeded at 1449 (offset -6 lines).
  Hunk #6 FAILED at 1510.
  1 out of 6 hunks FAILED -- saving rejects to file
Source/core/page/DOMWindow.cpp.rej

Patch:       Source/core/page/DOMWindow.cpp
Index: Source/core/page/DOMWindow.cpp
diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp
index
abe3beef55b4eca7afbfd16772a16b0d2e3bfea0..aaad69b97c6d51d5d03961f7528f2a34e4952a07
100644
--- a/Source/core/page/DOMWindow.cpp
+++ b/Source/core/page/DOMWindow.cpp
@@ -44,7 +44,6 @@
 #include "core/css/MediaQueryMatcher.h"
 #include "core/css/StyleMedia.h"
 #include "core/css/resolver/StyleResolver.h"
-#include "core/dom/DeviceOrientationController.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/EventListener.h"
@@ -94,6 +93,7 @@
 #include "core/storage/Storage.h"
 #include "core/storage/StorageArea.h"
 #include "core/storage/StorageNamespace.h"
+#include "modules/device_orientation/NewDeviceOrientationController.h"
 #include "weborigin/KURL.h"
 #include "weborigin/SecurityOrigin.h"
 #include "weborigin/SecurityPolicy.h"
@@ -433,8 +433,8 @@ void DOMWindow::willDetachPage()
     InspectorInstrumentation::frameWindowDiscarded(m_frame, this);
     // FIXME: Once DeviceOrientationController is a ScriptExecutionContext
     // Supplement, this will no longer be needed.
-    if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-        controller->removeAllDeviceEventListeners(this);
+    if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+        controller->stopUpdating();
 }
 
 void DOMWindow::willDestroyDocumentInFrame()
@@ -1431,8 +1431,8 @@ bool DOMWindow::addEventListener(const AtomicString&
eventType, PassRefPtr<Event
             UseCounter::count(this,
UseCounter::SubFrameBeforeUnloadRegistered);
         }
     } else if (eventType == eventNames().deviceorientationEvent &&
RuntimeEnabledFeatures::deviceOrientationEnabled()) {
-        if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-            controller->addDeviceEventListener(this);
+        if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+            controller->startUpdating();
     }
 
     return true;
@@ -1455,8 +1455,8 @@ bool DOMWindow::removeEventListener(const AtomicString&
eventType, EventListener
     } else if (eventType == eventNames().beforeunloadEvent &&
allowsBeforeUnloadListeners(this)) {
         removeBeforeUnloadEventListener(this);
     } else if (eventType == eventNames().deviceorientationEvent) {
-        if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-            controller->removeDeviceEventListener(this);
+        if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+            controller->stopUpdating();
     }
 
     return true;
@@ -1510,8 +1510,8 @@ void DOMWindow::removeAllEventListeners()
 
     lifecycleNotifier()->notifyRemoveAllEventListeners(this);
 
-    if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-        controller->removeAllDeviceEventListeners(this);
+    if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+        controller->stopUpdating();
     if (Document* document = this->document())
         document->didRemoveEventTargetNode(document);

[commit-bot: I haz the power, 2013-09-19 10:52:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22599005/37001

[commit-bot: I haz the power, 2013-09-19 11:49:42]

Change committed as 158028

[commit-bot: I haz the power, 2013-09-27 14:27:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22599005/37001

[commit-bot: I haz the power, 2013-09-27 14:27:37]

Failed to apply patch for Source/core/page/DOMWindow.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/page/DOMWindow.cpp
  Hunk #1 succeeded at 44 with fuzz 1.
  Hunk #4 succeeded at 1432 (offset 2 lines).
  Hunk #5 succeeded at 1456 (offset 7 lines).
  Hunk #6 FAILED at 1504.
  1 out of 6 hunks FAILED -- saving rejects to file
Source/core/page/DOMWindow.cpp.rej

Patch:       Source/core/page/DOMWindow.cpp
Index: Source/core/page/DOMWindow.cpp
diff --git a/Source/core/page/DOMWindow.cpp b/Source/core/page/DOMWindow.cpp
index
d77702d201afc518e81fdda952a8eb7394f5e8a3..0281c5a133631ed9b536682be594cf79d2a05661
100644
--- a/Source/core/page/DOMWindow.cpp
+++ b/Source/core/page/DOMWindow.cpp
@@ -44,7 +44,6 @@
 #include "core/css/MediaQueryMatcher.h"
 #include "core/css/StyleMedia.h"
 #include "core/css/resolver/StyleResolver.h"
-#include "core/dom/DeviceOrientationController.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/dom/EventListener.h"
@@ -95,6 +94,7 @@
 #include "core/storage/Storage.h"
 #include "core/storage/StorageArea.h"
 #include "core/storage/StorageNamespace.h"
+#include "modules/device_orientation/NewDeviceOrientationController.h"
 #include "weborigin/KURL.h"
 #include "weborigin/SecurityOrigin.h"
 #include "weborigin/SecurityPolicy.h"
@@ -434,8 +434,8 @@ void DOMWindow::willDetachPage()
     InspectorInstrumentation::frameWindowDiscarded(m_frame, this);
     // FIXME: Once DeviceOrientationController is a ScriptExecutionContext
     // Supplement, this will no longer be needed.
-    if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-        controller->removeAllDeviceEventListeners(this);
+    if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+        controller->stopUpdating();
 }
 
 void DOMWindow::willDestroyDocumentInFrame()
@@ -1430,8 +1430,8 @@ bool DOMWindow::addEventListener(const AtomicString&
eventType, PassRefPtr<Event
             UseCounter::count(this,
UseCounter::SubFrameBeforeUnloadRegistered);
         }
     } else if (eventType == eventNames().deviceorientationEvent &&
RuntimeEnabledFeatures::deviceOrientationEnabled()) {
-        if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-            controller->addDeviceEventListener(this);
+        if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+            controller->startUpdating();
     }
 
     return true;
@@ -1449,8 +1449,8 @@ bool DOMWindow::removeEventListener(const AtomicString&
eventType, EventListener
     } else if (eventType == eventNames().beforeunloadEvent &&
allowsBeforeUnloadListeners(this)) {
         removeBeforeUnloadEventListener(this);
     } else if (eventType == eventNames().deviceorientationEvent) {
-        if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-            controller->removeDeviceEventListener(this);
+        if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+            controller->stopUpdating();
     }
 
     return true;
@@ -1504,8 +1504,8 @@ void DOMWindow::removeAllEventListeners()
 
     lifecycleNotifier()->notifyRemoveAllEventListeners(this);
 
-    if (DeviceOrientationController* controller =
DeviceOrientationController::from(page()))
-        controller->removeAllDeviceEventListeners(this);
+    if (NewDeviceOrientationController* controller =
NewDeviceOrientationController::from(document()))
+        controller->stopUpdating();
 
     removeAllUnloadEventListeners(this);
     removeAllBeforeUnloadEventListeners(this);

[commit-bot: I haz the power, 2013-09-27 15:43:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22599005/49001

[commit-bot: I haz the power, 2013-09-27 16:39:22]

Change committed as 158454