[turbofan] Inline calls to CPP builtins

src/compiler/js-graph.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/typer.h"
 
 namespace v8 {
@@ skipping 19 matching lines @@
 }
 
 Node* JSGraph::CEntryStubConstant(int result_size) {
   if (result_size == 1) {
     return CACHED(kCEntryStubConstant,
                   HeapConstant(CEntryStub(isolate(), 1).GetCode()));
   }
   return HeapConstant(CEntryStub(isolate(), result_size).GetCode());
 }
 
+Node* JSGraph::CEntryStubConstant(int result_size, SaveFPRegsMode save_doubles,
+                                  ArgvMode argv_mode, bool builtin_exit_frame) {

[Jarin, 2016/08/19 09:01:10]

The JSGraph class should only have factories that do some caching. Please, add a
TODO for caching the most common constants here (or just implement caching for
the two nodes you need).

[jgruber, 2016/08/19 11:17:07]

Removed the newly added CEntryStubConstant and added caching for the two most
common cases.

+  CEntryStub stub(isolate(), result_size, save_doubles, argv_mode,
+                  builtin_exit_frame);
+  return HeapConstant(stub.GetCode());
+}
 
 Node* JSGraph::EmptyFixedArrayConstant() {
   return CACHED(kEmptyFixedArrayConstant,
                 HeapConstant(factory()->empty_fixed_array()));
 }
 
 Node* JSGraph::EmptyLiteralsArrayConstant() {
   return CACHED(kEmptyLiteralsArrayConstant,
                 HeapConstant(factory()->empty_literals_array()));
 }
@@ skipping 212 matching lines @@
   for (size_t i = 0; i < arraysize(cached_nodes_); i++) {
     if (Node* node = cached_nodes_[i]) {
       if (!node->IsDead()) nodes->push_back(node);
     }
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8