Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2259853002: Revert of Replace LANGUAGE_END with LAST_LANGUAGE_MODE (Closed)

Created:
4 years, 4 months ago by Michael Hablich
Modified:
4 years, 4 months ago
Reviewers:
neis, Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Replace LANGUAGE_END with LAST_LANGUAGE_MODE (patchset #1 id:1 of https://codereview.chromium.org/2257703003/ ) Reason for revert: Needed to land revert https://codereview.chromium.org/2257133002/ Original issue's description: > Replace LANGUAGE_END with LAST_LANGUAGE_MODE > > BUG= > > Committed: https://crrev.com/9324efca85710ebb14f21ef8476447e21cbe3f35 > Cr-Commit-Position: refs/heads/master@{#38707} TBR=neis@chromium.org,marja@chromium.org,verwaest@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/8fdf6031a52cc2890d0c86dd303e732014c99614 Cr-Commit-Position: refs/heads/master@{#38713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/ast/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-state.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Hablich
Created Revert of Replace LANGUAGE_END with LAST_LANGUAGE_MODE
4 years, 4 months ago (2016-08-18 12:04:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259853002/1
4 years, 4 months ago (2016-08-18 12:04:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 12:04:59 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:05:12 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fdf6031a52cc2890d0c86dd303e732014c99614
Cr-Commit-Position: refs/heads/master@{#38713}

Powered by Google App Engine
This is Rietveld 408576698