Make TypedArray::New fucntions crash on wrong lengths.

Make TypedArray::New fucntions crash on wrong lengths.

R=jkummerow@chromium.org
BUG=359802
LOG=N

Committed: https://code.google.com/p/v8/source/detail?r=20525

[Dmitry Lomov (no reviews), 2014-04-05 01:01:19]

PTAL

[Jakob Kummerow, 2014-04-06 11:41:15]

LGTM

https://codereview.chromium.org/225983005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/225983005/diff/1/src/api.cc#newcode6078
src/api.cc:6078: CHECK(length <= static_cast<size_t>(i::Smi::kMaxValue));
With the change below we should never hit this case, right? (Makes sense to keep
the check nevertheless.)

https://codereview.chromium.org/225983005/diff/1/src/api.cc#newcode6110
src/api.cc:6110: return Local<Type##Array>();                                   
      \
nit: indentation (2 spaces is enough)

[Dmitry Lomov (no reviews), 2014-04-07 05:54:22]

Comments addressed landing.

https://codereview.chromium.org/225983005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/225983005/diff/1/src/api.cc#newcode6078
src/api.cc:6078: CHECK(length <= static_cast<size_t>(i::Smi::kMaxValue));
On 2014/04/06 11:41:15, Jakob wrote:
> With the change below we should never hit this case, right? (Makes sense to
keep
> the check nevertheless.)
Exactly.

https://codereview.chromium.org/225983005/diff/1/src/api.cc#newcode6110
src/api.cc:6110: return Local<Type##Array>();                                   
      \
On 2014/04/06 11:41:15, Jakob wrote:
> nit: indentation (2 spaces is enough)

Done.

[Dmitry Lomov (no reviews), 2014-04-07 05:54:37]

Committed patchset #2 manually as r20525 (presubmit successful).