Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2259823008: Move chromium.perf.fyi Galaxy S5 Perf from android/perf to chromium recipe. (Closed)

Created:
4 years, 4 months ago by dtu
Modified:
4 years, 4 months ago
Reviewers:
martiniss
CC:
chromium-reviews, estaab, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, sullivan
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Move chromium.perf.fyi Galaxy S5 Perf from android/perf to chromium recipe. Just to see what happens. BUG=639530 Committed: https://chromium.googlesource.com/chromium/tools/build/+/2f7a693e8be0ed413ea0f8bc66a3d0a6a1d992e8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -911 lines) Patch
M masters/master.chromium.perf.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipes/android/perf.py View 1 chunk +0 lines, -3 lines 0 comments Download
D scripts/slave/recipes/android/perf.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 1 chunk +0 lines, -821 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json View 1 chunk +20 lines, -0 lines 1 comment Download
A + scripts/slave/recipes/chromium.expected/full_chromium_perf_fyi_Android_Galaxy_S5_Perf__1_.json View 8 chunks +128 lines, -86 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dtu
https://codereview.chromium.org/2259823008/diff/1/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json File scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json (right): https://codereview.chromium.org/2259823008/diff/1/scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json#newcode688 scripts/slave/recipes/chromium.expected/full_chromium_perf_Android_Builder.json:688: }, Because this builder is actually using the android/builder ...
4 years, 4 months ago (2016-08-20 00:23:16 UTC) #2
martiniss
lgtm
4 years, 4 months ago (2016-08-22 17:55:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259823008/1
4 years, 4 months ago (2016-08-22 18:15:36 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:30:15 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/2f7a693e8be0ed413ea0...

Powered by Google App Engine
This is Rietveld 408576698