Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2259823005:
Return color shader instead of 2-color gradient when color count is 1 (Closed)
DescriptionReturn color shader instead of 2-color gradient when color count is 1
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005
Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606
Committed: https://skia.googlesource.com/skia/+/e9fd0f8eafb68ff92aab257e9a7429eb29047327
Patch Set 1 #
Total comments: 2
Patch Set 2 : Use SkShader::MakeColorShader() #
Total comments: 1
Patch Set 3 : Remove unnecessary #include #Patch Set 4 : Restore macro for 2-pt conical gradients #Messages
Total messages: 22 (10 generated)
Description was changed from ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: ========== to ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 ==========
fmenozzi@google.com changed reviewers: + reed@google.com
Removed seemingly-pointless EXPAND_ONE_COLOR macro when creating gradients with a single color. ptal
https://codereview.chromium.org/2259823005/diff/1/src/effects/gradients/SkGra... File src/effects/gradients/SkGradientShader.cpp (right): https://codereview.chromium.org/2259823005/diff/1/src/effects/gradients/SkGra... src/effects/gradients/SkGradientShader.cpp:772: return sk_make_sp<SkColorShader>(colors[0]); SkShader::MakeColorShader(colors[0]) https://codereview.chromium.org/2259823005/diff/1/src/effects/gradients/SkGra... src/effects/gradients/SkGradientShader.cpp:793: return sk_make_sp<SkColorShader>(colors[0]); ditto
ptal
bump
lgtm w/ nit about unneeded include https://codereview.chromium.org/2259823005/diff/20001/src/effects/gradients/S... File src/effects/gradients/SkGradientShader.cpp (right): https://codereview.chromium.org/2259823005/diff/20001/src/effects/gradients/S... src/effects/gradients/SkGradientShader.cpp:14: #include "SkColorShader.h" this is no longer needed
The CQ bit was checked by fmenozzi@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2259823005/#ps40001 (title: "Remove unnecessary #include")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 ========== to ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2257993002/ by reed@google.com. The reason for reverting is: breaks 2-pt-conical, which can sometimes not draw anything.
Message was sent while issue was closed.
fmenozzi@google.com changed reviewers: + fmalita@chromium.org
Message was sent while issue was closed.
Restored EXPAND_1_COLOR macro for 2-pt conical gradients. ptal
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Description was changed from ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606 ========== to ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606 ==========
The CQ bit was checked by fmenozzi@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com Link to the patchset: https://codereview.chromium.org/2259823005/#ps60001 (title: "Restore macro for 2-pt conical gradients")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606 ========== to ========== Return color shader instead of 2-color gradient when color count is 1 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259823005 Committed: https://skia.googlesource.com/skia/+/da082a5767d7edfd3abe74fc683392422565a606 Committed: https://skia.googlesource.com/skia/+/e9fd0f8eafb68ff92aab257e9a7429eb29047327 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/e9fd0f8eafb68ff92aab257e9a7429eb29047327 |
