services/shell/public/cpp/interface_registry.h - Issue 2259823003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/shell/public/cpp/interface_registry.h

Issue 2259823003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/shell/background/tests/background_shell_unittest.cc ('k') | services/shell/public/cpp/lib/interface_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/shell/public/cpp/interface_registry.h

diff --git a/services/shell/public/cpp/interface_registry.h b/services/shell/public/cpp/interface_registry.h

index 9f1051e09bfbb44440c5363102d33fce8d4e162b..e53f4a20dd4d8a7754ad3d19b06aee4ec185489f 100644

--- a/services/shell/public/cpp/interface_registry.h

+++ b/services/shell/public/cpp/interface_registry.h

@@ -89,8 +89,7 @@ class InterfaceRegistry : public mojom::InterfaceProvider {

template <typename Interface>

bool AddInterface(InterfaceFactory<Interface>* factory) {

return SetInterfaceBinderForName(

- base::WrapUnique(

- new internal::InterfaceFactoryBinder<Interface>(factory)),

+ base::MakeUnique<internal::InterfaceFactoryBinder<Interface>>(factory),

Interface::Name_);

}

@@ -103,8 +102,8 @@ class InterfaceRegistry : public mojom::InterfaceProvider {

const scoped_refptr<base::SingleThreadTaskRunner>& task_runner =

nullptr) {

return SetInterfaceBinderForName(

- base::WrapUnique(

- new internal::CallbackBinder<Interface>(callback, task_runner)),

+ base::MakeUnique<internal::CallbackBinder<Interface>>(callback,

+ task_runner),

Interface::Name_);

}

bool AddInterface(