Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: net/websockets/websocket_channel_test.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/websockets/websocket_channel_test.cc
diff --git a/net/websockets/websocket_channel_test.cc b/net/websockets/websocket_channel_test.cc
index 6769de0c9b57e85f36e585f4532693bee0dd2462..f411f589d1a7f94d25cb83035b77d3e3c09b9150 100644
--- a/net/websockets/websocket_channel_test.cc
+++ b/net/websockets/websocket_channel_test.cc
@@ -471,8 +471,8 @@ class ReadableFakeWebSocketStream : public FakeWebSocketStream {
void PrepareReadFrames(IsSync async,
int error,
const InitFrame (&frames)[N]) {
- responses_.push_back(base::WrapUnique(
- new Response(async, error, CreateFrameVector(frames))));
+ responses_.push_back(
+ base::MakeUnique<Response>(async, error, CreateFrameVector(frames)));
}
// An alternate version of PrepareReadFrames for when we need to construct
@@ -482,13 +482,13 @@ class ReadableFakeWebSocketStream : public FakeWebSocketStream {
int error,
std::vector<std::unique_ptr<WebSocketFrame>> frames) {
responses_.push_back(
- base::WrapUnique(new Response(async, error, std::move(frames))));
+ base::MakeUnique<Response>(async, error, std::move(frames)));
}
// Prepares a fake error response (ie. there is no data).
void PrepareReadFramesError(IsSync async, int error) {
- responses_.push_back(base::WrapUnique(new Response(
- async, error, std::vector<std::unique_ptr<WebSocketFrame>>())));
+ responses_.push_back(base::MakeUnique<Response>(
+ async, error, std::vector<std::unique_ptr<WebSocketFrame>>()));
}
int ReadFrames(std::vector<std::unique_ptr<WebSocketFrame>>* frames,
@@ -927,7 +927,7 @@ class ChannelDeletingFakeWebSocketEventInterface
std::unique_ptr<WebSocketEventInterface>
WebSocketChannelDeletingTest::CreateEventInterface() {
- return base::WrapUnique(new ChannelDeletingFakeWebSocketEventInterface(this));
+ return base::MakeUnique<ChannelDeletingFakeWebSocketEventInterface>(this);
}
// Base class for tests which verify that EventInterface methods are called
@@ -1196,9 +1196,9 @@ TEST_F(WebSocketChannelDeletingTest, OnNotifyFinishOpeningHandshakeError) {
scoped_refptr<HttpResponseHeaders> response_headers(
new HttpResponseHeaders(""));
channel_->OnFinishOpeningHandshake(
- base::WrapUnique(new WebSocketHandshakeResponseInfo(
+ base::MakeUnique<WebSocketHandshakeResponseInfo>(
GURL("http://www.example.com/"), 200, "OK", response_headers,
- base::Time())));
+ base::Time()));
base::RunLoop().RunUntilIdle();
EXPECT_EQ(nullptr, channel_.get());
}
@@ -1367,7 +1367,7 @@ TEST_F(WebSocketChannelEventInterfaceTest, ProtocolPassed) {
CreateChannelAndConnect();
connect_data_.argument_saver.connect_delegate->OnSuccess(
- base::WrapUnique(new FakeWebSocketStream("Bob", "")));
+ base::MakeUnique<FakeWebSocketStream>("Bob", ""));
}
TEST_F(WebSocketChannelEventInterfaceTest, ExtensionsPassed) {
@@ -1378,7 +1378,7 @@ TEST_F(WebSocketChannelEventInterfaceTest, ExtensionsPassed) {
CreateChannelAndConnect();
connect_data_.argument_saver.connect_delegate->OnSuccess(
- base::WrapUnique(new FakeWebSocketStream("", "extension1, extension2")));
+ base::MakeUnique<FakeWebSocketStream>("", "extension1, extension2"));
}
// The first frames from the server can arrive together with the handshake, in
« no previous file with comments | « net/url_request/view_cache_helper_unittest.cc ('k') | net/websockets/websocket_deflate_predictor_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698