Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: net/url_request/url_request_unittest.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request_test_util.cc ('k') | net/url_request/view_cache_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_unittest.cc
diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc
index 325f745c98870852365dc6c27796c9d95eea4d86..77374eab54abc45bdce80aadeef862517130b548 100644
--- a/net/url_request/url_request_unittest.cc
+++ b/net/url_request/url_request_unittest.cc
@@ -751,8 +751,8 @@ class URLRequestTest : public PlatformTest {
"data", base::WrapUnique(new DataProtocolHandler));
#if !defined(DISABLE_FILE_SUPPORT)
job_factory_impl_->SetProtocolHandler(
- "file", base::WrapUnique(new FileProtocolHandler(
- base::ThreadTaskRunnerHandle::Get())));
+ "file", base::MakeUnique<FileProtocolHandler>(
+ base::ThreadTaskRunnerHandle::Get()));
#endif
}
@@ -5693,9 +5693,9 @@ TEST_F(URLRequestTestHTTP, PostFileTest) {
PathService::Get(base::DIR_SOURCE_ROOT, &path);
path = path.Append(kTestFilePath);
path = path.Append(FILE_PATH_LITERAL("with-headers.html"));
- element_readers.push_back(base::WrapUnique(new UploadFileElementReader(
+ element_readers.push_back(base::MakeUnique<UploadFileElementReader>(
base::ThreadTaskRunnerHandle::Get().get(), path, 0,
- std::numeric_limits<uint64_t>::max(), base::Time())));
+ std::numeric_limits<uint64_t>::max(), base::Time()));
r->set_upload(base::WrapUnique<UploadDataStream>(
new ElementsUploadDataStream(std::move(element_readers), 0)));
@@ -5734,11 +5734,11 @@ TEST_F(URLRequestTestHTTP, PostUnreadableFileTest) {
std::vector<std::unique_ptr<UploadElementReader>> element_readers;
- element_readers.push_back(base::WrapUnique(new UploadFileElementReader(
+ element_readers.push_back(base::MakeUnique<UploadFileElementReader>(
base::ThreadTaskRunnerHandle::Get().get(),
base::FilePath(FILE_PATH_LITERAL(
"c:\\path\\to\\non\\existant\\file.randomness.12345")),
- 0, std::numeric_limits<uint64_t>::max(), base::Time())));
+ 0, std::numeric_limits<uint64_t>::max(), base::Time()));
r->set_upload(base::WrapUnique<UploadDataStream>(
new ElementsUploadDataStream(std::move(element_readers), 0)));
@@ -9892,8 +9892,7 @@ class URLRequestTestFTP : public URLRequestTest {
void SetUpFactory() override {
// Add FTP support to the default URLRequestContext.
job_factory_impl_->SetProtocolHandler(
- "ftp",
- base::WrapUnique(new FtpProtocolHandler(&ftp_transaction_factory_)));
+ "ftp", base::MakeUnique<FtpProtocolHandler>(&ftp_transaction_factory_));
}
std::string GetTestFileContents() {
« no previous file with comments | « net/url_request/url_request_test_util.cc ('k') | net/url_request/view_cache_helper_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698