net/server/http_server.cc - Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/server/http_server.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/server/http_server.cc

diff --git a/net/server/http_server.cc b/net/server/http_server.cc

index 08d0706c3c73a870c4badbd54938355440087575..c362e1b080f40b749d973fa2bbf34e0624af4a87 100644

--- a/net/server/http_server.cc

+++ b/net/server/http_server.cc

@@ -239,8 +239,7 @@ int HttpServer::HandleReadResult(HttpConnection* connection, int rv) {

connection->socket()->GetPeerAddress(&request.peer);

if (request.HasHeaderValue("connection", "upgrade")) {

- connection->SetWebSocket(

- base::WrapUnique(new WebSocket(this, connection)));

+ connection->SetWebSocket(base::MakeUnique<WebSocket>(this, connection));

read_buf->DidConsume(pos);

delegate_->OnWebSocketRequest(connection->id(), request);

if (HasClosedConnection(connection))

« no previous file with comments | « net/quic/test_tools/quic_test_packet_maker.cc ('k') | net/server/web_socket_encoder.cc » ('j') | no next file with comments »