Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Side by Side Diff: net/url_request/url_request_test_util.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/url_request/url_request_test_job.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/url_request/url_request_test_util.h" 5 #include "net/url_request/url_request_test_util.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 if (!host_resolver()) 74 if (!host_resolver())
75 context_storage_.set_host_resolver( 75 context_storage_.set_host_resolver(
76 std::unique_ptr<HostResolver>(new MockCachingHostResolver())); 76 std::unique_ptr<HostResolver>(new MockCachingHostResolver()));
77 if (!proxy_service()) 77 if (!proxy_service())
78 context_storage_.set_proxy_service(ProxyService::CreateDirect()); 78 context_storage_.set_proxy_service(ProxyService::CreateDirect());
79 if (!cert_verifier()) 79 if (!cert_verifier())
80 context_storage_.set_cert_verifier(CertVerifier::CreateDefault()); 80 context_storage_.set_cert_verifier(CertVerifier::CreateDefault());
81 if (!transport_security_state()) { 81 if (!transport_security_state()) {
82 context_storage_.set_transport_security_state( 82 context_storage_.set_transport_security_state(
83 base::WrapUnique(new TransportSecurityState())); 83 base::MakeUnique<TransportSecurityState>());
84 } 84 }
85 if (!cert_transparency_verifier()) { 85 if (!cert_transparency_verifier()) {
86 context_storage_.set_cert_transparency_verifier( 86 context_storage_.set_cert_transparency_verifier(
87 base::WrapUnique(new MultiLogCTVerifier())); 87 base::MakeUnique<MultiLogCTVerifier>());
88 } 88 }
89 if (!ct_policy_enforcer()) { 89 if (!ct_policy_enforcer()) {
90 context_storage_.set_ct_policy_enforcer( 90 context_storage_.set_ct_policy_enforcer(
91 base::WrapUnique(new CTPolicyEnforcer)); 91 base::WrapUnique(new CTPolicyEnforcer));
92 } 92 }
93 if (!ssl_config_service()) 93 if (!ssl_config_service())
94 context_storage_.set_ssl_config_service(new SSLConfigServiceDefaults()); 94 context_storage_.set_ssl_config_service(new SSLConfigServiceDefaults());
95 if (!http_auth_handler_factory()) { 95 if (!http_auth_handler_factory()) {
96 context_storage_.set_http_auth_handler_factory( 96 context_storage_.set_http_auth_handler_factory(
97 HttpAuthHandlerFactory::CreateDefault(host_resolver())); 97 HttpAuthHandlerFactory::CreateDefault(host_resolver()));
98 } 98 }
99 if (!http_server_properties()) { 99 if (!http_server_properties()) {
100 context_storage_.set_http_server_properties( 100 context_storage_.set_http_server_properties(
101 std::unique_ptr<HttpServerProperties>(new HttpServerPropertiesImpl())); 101 std::unique_ptr<HttpServerProperties>(new HttpServerPropertiesImpl()));
102 } 102 }
103 // In-memory cookie store. 103 // In-memory cookie store.
104 if (!cookie_store()) { 104 if (!cookie_store()) {
105 context_storage_.set_cookie_store( 105 context_storage_.set_cookie_store(
106 base::WrapUnique(new CookieMonster(nullptr, nullptr))); 106 base::MakeUnique<CookieMonster>(nullptr, nullptr));
107 } 107 }
108 // In-memory Channel ID service. Must be created before the 108 // In-memory Channel ID service. Must be created before the
109 // HttpNetworkSession. 109 // HttpNetworkSession.
110 if (!channel_id_service()) { 110 if (!channel_id_service()) {
111 context_storage_.set_channel_id_service(base::WrapUnique( 111 context_storage_.set_channel_id_service(base::MakeUnique<ChannelIDService>(
112 new ChannelIDService(new DefaultChannelIDStore(nullptr), 112 new DefaultChannelIDStore(nullptr),
113 base::WorkerPool::GetTaskRunner(true)))); 113 base::WorkerPool::GetTaskRunner(true)));
114 } 114 }
115 if (http_transaction_factory()) { 115 if (http_transaction_factory()) {
116 // Make sure we haven't been passed an object we're not going to use. 116 // Make sure we haven't been passed an object we're not going to use.
117 EXPECT_FALSE(client_socket_factory_); 117 EXPECT_FALSE(client_socket_factory_);
118 } else { 118 } else {
119 HttpNetworkSession::Params params; 119 HttpNetworkSession::Params params;
120 120
121 if (http_network_session_params_) 121 if (http_network_session_params_)
122 params = *http_network_session_params_; 122 params = *http_network_session_params_;
123 params.client_socket_factory = client_socket_factory(); 123 params.client_socket_factory = client_socket_factory();
124 params.proxy_delegate = proxy_delegate(); 124 params.proxy_delegate = proxy_delegate();
125 params.host_resolver = host_resolver(); 125 params.host_resolver = host_resolver();
126 params.cert_verifier = cert_verifier(); 126 params.cert_verifier = cert_verifier();
127 params.cert_transparency_verifier = cert_transparency_verifier(); 127 params.cert_transparency_verifier = cert_transparency_verifier();
128 params.ct_policy_enforcer = ct_policy_enforcer(); 128 params.ct_policy_enforcer = ct_policy_enforcer();
129 params.transport_security_state = transport_security_state(); 129 params.transport_security_state = transport_security_state();
130 params.proxy_service = proxy_service(); 130 params.proxy_service = proxy_service();
131 params.ssl_config_service = ssl_config_service(); 131 params.ssl_config_service = ssl_config_service();
132 params.http_auth_handler_factory = http_auth_handler_factory(); 132 params.http_auth_handler_factory = http_auth_handler_factory();
133 params.http_server_properties = http_server_properties(); 133 params.http_server_properties = http_server_properties();
134 params.net_log = net_log(); 134 params.net_log = net_log();
135 params.channel_id_service = channel_id_service(); 135 params.channel_id_service = channel_id_service();
136 context_storage_.set_http_network_session( 136 context_storage_.set_http_network_session(
137 base::WrapUnique(new HttpNetworkSession(params))); 137 base::MakeUnique<HttpNetworkSession>(params));
138 context_storage_.set_http_transaction_factory(base::WrapUnique( 138 context_storage_.set_http_transaction_factory(base::MakeUnique<HttpCache>(
139 new HttpCache(context_storage_.http_network_session(), 139 context_storage_.http_network_session(),
140 HttpCache::DefaultBackend::InMemory(0), false))); 140 HttpCache::DefaultBackend::InMemory(0), false));
141 } 141 }
142 if (!http_user_agent_settings()) { 142 if (!http_user_agent_settings()) {
143 context_storage_.set_http_user_agent_settings(base::WrapUnique( 143 context_storage_.set_http_user_agent_settings(
144 new StaticHttpUserAgentSettings("en-us,fr", std::string()))); 144 base::MakeUnique<StaticHttpUserAgentSettings>("en-us,fr",
145 std::string()));
145 } 146 }
146 if (!job_factory()) { 147 if (!job_factory()) {
147 context_storage_.set_job_factory( 148 context_storage_.set_job_factory(
148 base::WrapUnique(new URLRequestJobFactoryImpl())); 149 base::MakeUnique<URLRequestJobFactoryImpl>());
149 } 150 }
150 } 151 }
151 152
152 TestURLRequestContextGetter::TestURLRequestContextGetter( 153 TestURLRequestContextGetter::TestURLRequestContextGetter(
153 const scoped_refptr<base::SingleThreadTaskRunner>& network_task_runner) 154 const scoped_refptr<base::SingleThreadTaskRunner>& network_task_runner)
154 : network_task_runner_(network_task_runner) { 155 : network_task_runner_(network_task_runner) {
155 DCHECK(network_task_runner_.get()); 156 DCHECK(network_task_runner_.get());
156 } 157 }
157 158
158 TestURLRequestContextGetter::TestURLRequestContextGetter( 159 TestURLRequestContextGetter::TestURLRequestContextGetter(
(...skipping 506 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 NetworkDelegate* network_delegate) const { 666 NetworkDelegate* network_delegate) const {
666 return main_intercept_job_.release(); 667 return main_intercept_job_.release();
667 } 668 }
668 669
669 void TestJobInterceptor::set_main_intercept_job( 670 void TestJobInterceptor::set_main_intercept_job(
670 std::unique_ptr<URLRequestJob> job) { 671 std::unique_ptr<URLRequestJob> job) {
671 main_intercept_job_ = std::move(job); 672 main_intercept_job_ = std::move(job);
672 } 673 }
673 674
674 } // namespace net 675 } // namespace net
OLDNEW
« no previous file with comments | « net/url_request/url_request_test_job.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698