Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: net/quic/test_tools/quic_test_packet_maker.cc

Issue 2259823002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/chromium/quic_stream_factory.cc ('k') | net/server/http_server.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/test_tools/quic_test_packet_maker.h" 5 #include "net/quic/test_tools/quic_test_packet_maker.h"
6 6
7 #include <list> 7 #include <list>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/memory/ptr_util.h" 10 #include "base/memory/ptr_util.h"
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 bool fin, 308 bool fin,
309 QuicStreamOffset offset, 309 QuicStreamOffset offset,
310 const std::vector<std::string>& data_writes) { 310 const std::vector<std::string>& data_writes) {
311 InitializeHeader(packet_number, should_include_version); 311 InitializeHeader(packet_number, should_include_version);
312 QuicFrames data_frames; 312 QuicFrames data_frames;
313 // QuicFrame takes a raw pointer. Use a std::vector here so we keep 313 // QuicFrame takes a raw pointer. Use a std::vector here so we keep
314 // StreamFrames alive until MakeMultipleFramesPacket is done. 314 // StreamFrames alive until MakeMultipleFramesPacket is done.
315 std::vector<std::unique_ptr<QuicStreamFrame>> stream_frames; 315 std::vector<std::unique_ptr<QuicStreamFrame>> stream_frames;
316 for (size_t i = 0; i < data_writes.size(); ++i) { 316 for (size_t i = 0; i < data_writes.size(); ++i) {
317 bool is_fin = fin && (i == data_writes.size() - 1); 317 bool is_fin = fin && (i == data_writes.size() - 1);
318 stream_frames.push_back(base::WrapUnique(new QuicStreamFrame( 318 stream_frames.push_back(base::MakeUnique<QuicStreamFrame>(
319 stream_id, is_fin, offset, base::StringPiece(data_writes[i])))); 319 stream_id, is_fin, offset, base::StringPiece(data_writes[i])));
320 offset += data_writes[i].length(); 320 offset += data_writes[i].length();
321 } 321 }
322 for (const auto& stream_frame : stream_frames) { 322 for (const auto& stream_frame : stream_frames) {
323 QuicFrame quic_frame(stream_frame.get()); 323 QuicFrame quic_frame(stream_frame.get());
324 DVLOG(1) << "Adding frame: " << quic_frame; 324 DVLOG(1) << "Adding frame: " << quic_frame;
325 data_frames.push_back(quic_frame); 325 data_frames.push_back(quic_frame);
326 } 326 }
327 return MakeMultipleFramesPacket(header_, data_frames); 327 return MakeMultipleFramesPacket(header_, data_frames);
328 } 328 }
329 329
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 393
394 QuicFrames frames; 394 QuicFrames frames;
395 frames.push_back(QuicFrame(&frame)); 395 frames.push_back(QuicFrame(&frame));
396 396
397 QuicStreamOffset offset = 0; 397 QuicStreamOffset offset = 0;
398 // QuicFrame takes a raw pointer. Use a std::vector here so we keep 398 // QuicFrame takes a raw pointer. Use a std::vector here so we keep
399 // StreamFrames alive until MakeMultipleFramesPacket is done. 399 // StreamFrames alive until MakeMultipleFramesPacket is done.
400 std::vector<std::unique_ptr<QuicStreamFrame>> stream_frames; 400 std::vector<std::unique_ptr<QuicStreamFrame>> stream_frames;
401 for (size_t i = 0; i < data_writes.size(); ++i) { 401 for (size_t i = 0; i < data_writes.size(); ++i) {
402 bool is_fin = fin && (i == data_writes.size() - 1); 402 bool is_fin = fin && (i == data_writes.size() - 1);
403 stream_frames.push_back(base::WrapUnique(new QuicStreamFrame( 403 stream_frames.push_back(base::MakeUnique<QuicStreamFrame>(
404 stream_id, is_fin, offset, base::StringPiece(data_writes[i])))); 404 stream_id, is_fin, offset, base::StringPiece(data_writes[i])));
405 offset += data_writes[i].length(); 405 offset += data_writes[i].length();
406 } 406 }
407 for (const auto& stream_frame : stream_frames) { 407 for (const auto& stream_frame : stream_frames) {
408 QuicFrame quic_frame(stream_frame.get()); 408 QuicFrame quic_frame(stream_frame.get());
409 DVLOG(1) << "Adding frame: " << quic_frame; 409 DVLOG(1) << "Adding frame: " << quic_frame;
410 frames.push_back(quic_frame); 410 frames.push_back(quic_frame);
411 } 411 }
412 return MakeMultipleFramesPacket(header_, frames); 412 return MakeMultipleFramesPacket(header_, frames);
413 } 413 }
414 414
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
663 header_.public_header.reset_flag = false; 663 header_.public_header.reset_flag = false;
664 header_.public_header.version_flag = should_include_version; 664 header_.public_header.version_flag = should_include_version;
665 header_.public_header.packet_number_length = PACKET_1BYTE_PACKET_NUMBER; 665 header_.public_header.packet_number_length = PACKET_1BYTE_PACKET_NUMBER;
666 header_.packet_number = packet_number; 666 header_.packet_number = packet_number;
667 header_.entropy_flag = false; 667 header_.entropy_flag = false;
668 header_.fec_flag = false; 668 header_.fec_flag = false;
669 } 669 }
670 670
671 } // namespace test 671 } // namespace test
672 } // namespace net 672 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/chromium/quic_stream_factory.cc ('k') | net/server/http_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698