components/password_manager/core/browser/password_store_unittest.cc - Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique()

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_factory_util.cc ('k') | components/password_manager/sync/browser/sync_credentials_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc

index c268251439e8000e4f6d070eb5f36f400fd89ce8..dd10499eb3441159c27ac34bec469aee3b02f332 100644

--- a/components/password_manager/core/browser/password_store_unittest.cc

+++ b/components/password_manager/core/browser/password_store_unittest.cc

@@ -104,7 +104,7 @@ ACTION(STLDeleteElements0) {

TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

- base::WrapUnique(new LoginDatabase(test_login_db_file_path()))));

+ base::MakeUnique<LoginDatabase>(test_login_db_file_path())));

store->Init(syncer::SyncableService::StartSyncFlare());

const time_t cutoff = 1325376000; // 00:00 Jan 1 2012 UTC

@@ -197,7 +197,7 @@ TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {

TEST_F(PasswordStoreTest, StartSyncFlare) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

- base::WrapUnique(new LoginDatabase(test_login_db_file_path()))));

+ base::MakeUnique<LoginDatabase>(test_login_db_file_path())));

StartSyncFlareMock mock;

store->Init(

base::Bind(&StartSyncFlareMock::StartSyncFlare, base::Unretained(&mock)));

@@ -226,7 +226,7 @@ TEST_F(PasswordStoreTest, GetLoginImpl) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

- base::WrapUnique(new LoginDatabase(test_login_db_file_path()))));

+ base::MakeUnique<LoginDatabase>(test_login_db_file_path())));

store->Init(syncer::SyncableService::StartSyncFlare());

// For each attribute in the primary key, create one form that mismatches on

@@ -289,7 +289,7 @@ TEST_F(PasswordStoreTest, UpdateLoginPrimaryKeyFields) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

base::ThreadTaskRunnerHandle::Get(), base::ThreadTaskRunnerHandle::Get(),

- base::WrapUnique(new LoginDatabase(test_login_db_file_path()))));

+ base::MakeUnique<LoginDatabase>(test_login_db_file_path())));

store->Init(syncer::SyncableService::StartSyncFlare());

std::unique_ptr<PasswordForm> old_form(

@@ -785,7 +785,7 @@ TEST_F(PasswordStoreTest, GetLoginsWithAffiliatedRealms) {

scoped_refptr<PasswordStoreDefault> store(new PasswordStoreDefault(

base::ThreadTaskRunnerHandle::Get(),

- base::WrapUnique(new LoginDatabase(test_login_db_file_path()))));

+ base::MakeUnique<LoginDatabase>(test_login_db_file_path())));

store->Init(syncer::SyncableService::StartSyncFlare());

store->RemoveLoginsCreatedBetween(base::Time(), base::Time::Max(),

base::Closure());