components/password_manager/core/browser/export/password_csv_writer_unittest.cc - Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/export/password_csv_writer_unittest.cc

Issue 2259813002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/affiliation_fetch_throttler_unittest.cc ('k') | components/password_manager/core/browser/export/password_exporter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/export/password_csv_writer_unittest.cc

diff --git a/components/password_manager/core/browser/export/password_csv_writer_unittest.cc b/components/password_manager/core/browser/export/password_csv_writer_unittest.cc

index fc231b8df7e2ad7c584390ab2432f03c0a15e9a9..384940fbe12c2504dae95ce5767fa20873b1da41 100644

--- a/components/password_manager/core/browser/export/password_csv_writer_unittest.cc

+++ b/components/password_manager/core/browser/export/password_csv_writer_unittest.cc

@@ -39,7 +39,7 @@ TEST(PasswordCSVWriterTest, SerializePasswords_SinglePassword) {

form.origin = GURL("http://example.com");

form.username_value = base::UTF8ToUTF16("Someone");

form.password_value = base::UTF8ToUTF16("Secret");

- passwords.push_back(base::WrapUnique(new PasswordForm(form)));

+ passwords.push_back(base::MakeUnique<PasswordForm>(form));

std::vector<std::string> column_names;

std::vector<std::map<std::string, std::string>> records;

@@ -60,11 +60,11 @@ TEST(PasswordCSVWriterTest, SerializePasswords_TwoPasswords) {

form.origin = GURL("http://example.com");

form.username_value = base::UTF8ToUTF16("Someone");

form.password_value = base::UTF8ToUTF16("Secret");

- passwords.push_back(base::WrapUnique(new PasswordForm(form)));

+ passwords.push_back(base::MakeUnique<PasswordForm>(form));

form.origin = GURL("http://other.org");

form.username_value = base::UTF8ToUTF16("Anyone");

form.password_value = base::UTF8ToUTF16("None");

- passwords.push_back(base::WrapUnique(new PasswordForm(form)));

+ passwords.push_back(base::MakeUnique<PasswordForm>(form));

std::vector<std::string> column_names;

std::vector<std::map<std::string, std::string>> records;