Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2259763002: Remove DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED macro. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-wtf_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, Mikhail, mlamouri+watch-blink_chromium.org, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES_REFCOUNTED macro. Only Node and Frame used it, and it didn't make sense because they are not ref-counted. This CL has no behavior changes. Committed: https://crrev.com/ab75b5d193675895a8bd8f30a31ebfb76638c5ac Cr-Commit-Position: refs/heads/master@{#412769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/Assertions.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yutak@, would you review this please?
4 years, 4 months ago (2016-08-18 07:49:10 UTC) #5
Yuta Kitamura
lgtm
4 years, 4 months ago (2016-08-18 08:04:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259763002/1
4 years, 4 months ago (2016-08-18 08:21:40 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:25:40 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:27:34 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab75b5d193675895a8bd8f30a31ebfb76638c5ac
Cr-Commit-Position: refs/heads/master@{#412769}

Powered by Google App Engine
This is Rietveld 408576698