Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: ui/views/style/mac/dialog_button_border_mac_unittest.cc

Issue 2259753003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/painter.cc ('k') | ui/views/style/platform_style.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/views/style/mac/dialog_button_border_mac.h" 5 #include "ui/views/style/mac/dialog_button_border_mac.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "third_party/skia/include/core/SkCanvas.h" 10 #include "third_party/skia/include/core/SkCanvas.h"
(...skipping 13 matching lines...) Expand all
24 : LabelButton(nullptr, base::ASCIIToUTF16(text)) {} 24 : LabelButton(nullptr, base::ASCIIToUTF16(text)) {}
25 25
26 void SimulateAddToWidget() { OnNativeThemeChanged(nullptr); } 26 void SimulateAddToWidget() { OnNativeThemeChanged(nullptr); }
27 void set_provide_custom_border(bool value) { provide_custom_border_ = value; } 27 void set_provide_custom_border(bool value) { provide_custom_border_ = value; }
28 28
29 // LabelButton: 29 // LabelButton:
30 std::unique_ptr<LabelButtonBorder> CreateDefaultBorder() const override { 30 std::unique_ptr<LabelButtonBorder> CreateDefaultBorder() const override {
31 if (!provide_custom_border_) 31 if (!provide_custom_border_)
32 return LabelButton::CreateDefaultBorder(); 32 return LabelButton::CreateDefaultBorder();
33 33
34 return base::WrapUnique(new LabelButtonAssetBorder(style())); 34 return base::MakeUnique<LabelButtonAssetBorder>(style());
35 } 35 }
36 36
37 private: 37 private:
38 bool provide_custom_border_ = false; 38 bool provide_custom_border_ = false;
39 39
40 DISALLOW_COPY_AND_ASSIGN(TestLabelButton); 40 DISALLOW_COPY_AND_ASSIGN(TestLabelButton);
41 }; 41 };
42 42
43 gfx::Size DialogButtonBorderMacSize() { 43 gfx::Size DialogButtonBorderMacSize() {
44 const DialogButtonBorderMac template_border; 44 const DialogButtonBorderMac template_border;
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 191
192 // Any call to SetBorder() will immediately prevent themed buttons and adding 192 // Any call to SetBorder() will immediately prevent themed buttons and adding
193 // to a Widget (to pick up a NativeTheme) shouldn't restore them. 193 // to a Widget (to pick up a NativeTheme) shouldn't restore them.
194 button.SetBorder(Border::NullBorder()); 194 button.SetBorder(Border::NullBorder());
195 EXPECT_FALSE(BorderIsDialogButton(button)); 195 EXPECT_FALSE(BorderIsDialogButton(button));
196 button.SimulateAddToWidget(); 196 button.SimulateAddToWidget();
197 EXPECT_FALSE(BorderIsDialogButton(button)); 197 EXPECT_FALSE(BorderIsDialogButton(button));
198 } 198 }
199 199
200 } // namespace views 200 } // namespace views
OLDNEW
« no previous file with comments | « ui/views/painter.cc ('k') | ui/views/style/platform_style.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698