Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: ui/message_center/message_center_impl_unittest.cc

Issue 2259753003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/gl/gl_context.cc ('k') | ui/message_center/message_center_tray.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/message_center/message_center_impl.h" 5 #include "ui/message_center/message_center_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/location.h" 10 #include "base/location.h"
(...skipping 237 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 const std::string& last_id() const { return last_id_; } 248 const std::string& last_id() const { return last_id_; }
249 249
250 private: 250 private:
251 bool timer_finished_; 251 bool timer_finished_;
252 std::string last_id_; 252 std::string last_id_;
253 base::Closure quit_closure_; 253 base::Closure quit_closure_;
254 }; 254 };
255 255
256 TEST_F(MessageCenterImplTest, PopupTimersEmptyController) { 256 TEST_F(MessageCenterImplTest, PopupTimersEmptyController) {
257 std::unique_ptr<PopupTimersController> popup_timers_controller = 257 std::unique_ptr<PopupTimersController> popup_timers_controller =
258 base::WrapUnique(new PopupTimersController(message_center())); 258 base::MakeUnique<PopupTimersController>(message_center());
259 259
260 // Test that all functions succed without any timers created. 260 // Test that all functions succed without any timers created.
261 popup_timers_controller->PauseAll(); 261 popup_timers_controller->PauseAll();
262 popup_timers_controller->StartAll(); 262 popup_timers_controller->StartAll();
263 popup_timers_controller->CancelAll(); 263 popup_timers_controller->CancelAll();
264 popup_timers_controller->TimerFinished("unknown"); 264 popup_timers_controller->TimerFinished("unknown");
265 popup_timers_controller->PauseTimer("unknown"); 265 popup_timers_controller->PauseTimer("unknown");
266 popup_timers_controller->CancelTimer("unknown"); 266 popup_timers_controller->CancelTimer("unknown");
267 } 267 }
268 268
269 TEST_F(MessageCenterImplTest, PopupTimersControllerStartTimer) { 269 TEST_F(MessageCenterImplTest, PopupTimersControllerStartTimer) {
270 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 270 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
271 base::WrapUnique( 271 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
272 new MockPopupTimersController(message_center(), closure()));
273 popup_timers_controller->StartTimer("test", 272 popup_timers_controller->StartTimer("test",
274 base::TimeDelta::FromMilliseconds(1)); 273 base::TimeDelta::FromMilliseconds(1));
275 run_loop()->Run(); 274 run_loop()->Run();
276 EXPECT_TRUE(popup_timers_controller->timer_finished()); 275 EXPECT_TRUE(popup_timers_controller->timer_finished());
277 } 276 }
278 277
279 TEST_F(MessageCenterImplTest, PopupTimersControllerPauseTimer) { 278 TEST_F(MessageCenterImplTest, PopupTimersControllerPauseTimer) {
280 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 279 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
281 base::WrapUnique( 280 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
282 new MockPopupTimersController(message_center(), closure()));
283 popup_timers_controller->StartTimer("test", 281 popup_timers_controller->StartTimer("test",
284 base::TimeDelta::FromMilliseconds(1)); 282 base::TimeDelta::FromMilliseconds(1));
285 popup_timers_controller->PauseTimer("test"); 283 popup_timers_controller->PauseTimer("test");
286 run_loop()->RunUntilIdle(); 284 run_loop()->RunUntilIdle();
287 285
288 EXPECT_FALSE(popup_timers_controller->timer_finished()); 286 EXPECT_FALSE(popup_timers_controller->timer_finished());
289 } 287 }
290 288
291 TEST_F(MessageCenterImplTest, PopupTimersControllerCancelTimer) { 289 TEST_F(MessageCenterImplTest, PopupTimersControllerCancelTimer) {
292 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 290 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
293 base::WrapUnique( 291 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
294 new MockPopupTimersController(message_center(), closure()));
295 popup_timers_controller->StartTimer("test", 292 popup_timers_controller->StartTimer("test",
296 base::TimeDelta::FromMilliseconds(1)); 293 base::TimeDelta::FromMilliseconds(1));
297 popup_timers_controller->CancelTimer("test"); 294 popup_timers_controller->CancelTimer("test");
298 run_loop()->RunUntilIdle(); 295 run_loop()->RunUntilIdle();
299 296
300 EXPECT_FALSE(popup_timers_controller->timer_finished()); 297 EXPECT_FALSE(popup_timers_controller->timer_finished());
301 } 298 }
302 299
303 TEST_F(MessageCenterImplTest, PopupTimersControllerPauseAllTimers) { 300 TEST_F(MessageCenterImplTest, PopupTimersControllerPauseAllTimers) {
304 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 301 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
305 base::WrapUnique( 302 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
306 new MockPopupTimersController(message_center(), closure()));
307 popup_timers_controller->StartTimer("test", 303 popup_timers_controller->StartTimer("test",
308 base::TimeDelta::FromMilliseconds(1)); 304 base::TimeDelta::FromMilliseconds(1));
309 popup_timers_controller->PauseAll(); 305 popup_timers_controller->PauseAll();
310 run_loop()->RunUntilIdle(); 306 run_loop()->RunUntilIdle();
311 307
312 EXPECT_FALSE(popup_timers_controller->timer_finished()); 308 EXPECT_FALSE(popup_timers_controller->timer_finished());
313 } 309 }
314 310
315 TEST_F(MessageCenterImplTest, PopupTimersControllerStartAllTimers) { 311 TEST_F(MessageCenterImplTest, PopupTimersControllerStartAllTimers) {
316 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 312 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
317 base::WrapUnique( 313 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
318 new MockPopupTimersController(message_center(), closure()));
319 popup_timers_controller->StartTimer("test", 314 popup_timers_controller->StartTimer("test",
320 base::TimeDelta::FromMilliseconds(1)); 315 base::TimeDelta::FromMilliseconds(1));
321 popup_timers_controller->PauseAll(); 316 popup_timers_controller->PauseAll();
322 popup_timers_controller->StartAll(); 317 popup_timers_controller->StartAll();
323 run_loop()->Run(); 318 run_loop()->Run();
324 319
325 EXPECT_TRUE(popup_timers_controller->timer_finished()); 320 EXPECT_TRUE(popup_timers_controller->timer_finished());
326 } 321 }
327 322
328 TEST_F(MessageCenterImplTest, PopupTimersControllerStartMultipleTimers) { 323 TEST_F(MessageCenterImplTest, PopupTimersControllerStartMultipleTimers) {
329 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 324 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
330 base::WrapUnique( 325 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
331 new MockPopupTimersController(message_center(), closure()));
332 popup_timers_controller->StartTimer("test", 326 popup_timers_controller->StartTimer("test",
333 base::TimeDelta::FromMilliseconds(5)); 327 base::TimeDelta::FromMilliseconds(5));
334 popup_timers_controller->StartTimer("test2", 328 popup_timers_controller->StartTimer("test2",
335 base::TimeDelta::FromMilliseconds(1)); 329 base::TimeDelta::FromMilliseconds(1));
336 popup_timers_controller->StartTimer("test3", 330 popup_timers_controller->StartTimer("test3",
337 base::TimeDelta::FromMilliseconds(3)); 331 base::TimeDelta::FromMilliseconds(3));
338 popup_timers_controller->PauseAll(); 332 popup_timers_controller->PauseAll();
339 popup_timers_controller->StartAll(); 333 popup_timers_controller->StartAll();
340 run_loop()->Run(); 334 run_loop()->Run();
341 335
342 EXPECT_EQ(popup_timers_controller->last_id(), "test2"); 336 EXPECT_EQ(popup_timers_controller->last_id(), "test2");
343 EXPECT_TRUE(popup_timers_controller->timer_finished()); 337 EXPECT_TRUE(popup_timers_controller->timer_finished());
344 } 338 }
345 339
346 TEST_F(MessageCenterImplTest, PopupTimersControllerStartMultipleTimersPause) { 340 TEST_F(MessageCenterImplTest, PopupTimersControllerStartMultipleTimersPause) {
347 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 341 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
348 base::WrapUnique( 342 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
349 new MockPopupTimersController(message_center(), closure()));
350 popup_timers_controller->StartTimer("test", 343 popup_timers_controller->StartTimer("test",
351 base::TimeDelta::FromMilliseconds(5)); 344 base::TimeDelta::FromMilliseconds(5));
352 popup_timers_controller->StartTimer("test2", 345 popup_timers_controller->StartTimer("test2",
353 base::TimeDelta::FromMilliseconds(1)); 346 base::TimeDelta::FromMilliseconds(1));
354 popup_timers_controller->StartTimer("test3", 347 popup_timers_controller->StartTimer("test3",
355 base::TimeDelta::FromMilliseconds(3)); 348 base::TimeDelta::FromMilliseconds(3));
356 popup_timers_controller->PauseTimer("test2"); 349 popup_timers_controller->PauseTimer("test2");
357 350
358 run_loop()->Run(); 351 run_loop()->Run();
359 352
360 EXPECT_EQ(popup_timers_controller->last_id(), "test3"); 353 EXPECT_EQ(popup_timers_controller->last_id(), "test3");
361 EXPECT_TRUE(popup_timers_controller->timer_finished()); 354 EXPECT_TRUE(popup_timers_controller->timer_finished());
362 } 355 }
363 356
364 TEST_F(MessageCenterImplTest, PopupTimersControllerResetTimer) { 357 TEST_F(MessageCenterImplTest, PopupTimersControllerResetTimer) {
365 std::unique_ptr<MockPopupTimersController> popup_timers_controller = 358 std::unique_ptr<MockPopupTimersController> popup_timers_controller =
366 base::WrapUnique( 359 base::MakeUnique<MockPopupTimersController>(message_center(), closure());
367 new MockPopupTimersController(message_center(), closure()));
368 popup_timers_controller->StartTimer("test", 360 popup_timers_controller->StartTimer("test",
369 base::TimeDelta::FromMilliseconds(5)); 361 base::TimeDelta::FromMilliseconds(5));
370 popup_timers_controller->StartTimer("test2", 362 popup_timers_controller->StartTimer("test2",
371 base::TimeDelta::FromMilliseconds(1)); 363 base::TimeDelta::FromMilliseconds(1));
372 popup_timers_controller->StartTimer("test3", 364 popup_timers_controller->StartTimer("test3",
373 base::TimeDelta::FromMilliseconds(3)); 365 base::TimeDelta::FromMilliseconds(3));
374 popup_timers_controller->PauseTimer("test2"); 366 popup_timers_controller->PauseTimer("test2");
375 popup_timers_controller->ResetTimer("test", 367 popup_timers_controller->ResetTimer("test",
376 base::TimeDelta::FromMilliseconds(2)); 368 base::TimeDelta::FromMilliseconds(2));
377 369
(...skipping 791 matching lines...) Expand 10 before | Expand all | Expand 10 after
1169 // Then open the message center. 1161 // Then open the message center.
1170 message_center()->SetVisibility(VISIBILITY_MESSAGE_CENTER); 1162 message_center()->SetVisibility(VISIBILITY_MESSAGE_CENTER);
1171 1163
1172 // Then update a notification; the update should have propagated. 1164 // Then update a notification; the update should have propagated.
1173 message_center()->RemoveNotification(id, false); 1165 message_center()->RemoveNotification(id, false);
1174 EXPECT_FALSE(message_center()->FindVisibleNotificationById(id)); 1166 EXPECT_FALSE(message_center()->FindVisibleNotificationById(id));
1175 } 1167 }
1176 1168
1177 } // namespace internal 1169 } // namespace internal
1178 } // namespace message_center 1170 } // namespace message_center
OLDNEW
« no previous file with comments | « ui/gl/gl_context.cc ('k') | ui/message_center/message_center_tray.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698