Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2259753002: Fix nullptr dereference in MojoShellConnectionImpl (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nullptr dereference in MojoShellConnectionImpl ShutdownOnIOThread may be called more than once. If this happens, the MessageLoop observer will be null during the second call. This ensures that we don't dereference it in that case. BUG=None TBR=ben@chromium.org Committed: https://crrev.com/6854da52a2abf8b9f1b56863eb9f6e30ea8a52e5 Cr-Commit-Position: refs/heads/master@{#412768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/common/mojo/mojo_shell_connection_impl.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259753002/1
4 years, 4 months ago (2016-08-18 06:31:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 08:16:18 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 08:18:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6854da52a2abf8b9f1b56863eb9f6e30ea8a52e5
Cr-Commit-Position: refs/heads/master@{#412768}

Powered by Google App Engine
This is Rietveld 408576698