Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2259733002: Require certain faimilies to contain certain styles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a dcheck and don't block attempted loading if font cannot be loaded at all Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 6b0076d10371e7670afd12fc5c63ad44d2db96bb..aa47745e900619743bf61aede8c5645b895bb0a1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -72980,6 +72980,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="0" label="File: system font directory"/>
<int value="1" label="File: outside sandbox whitelist"/>
<int value="2" label="Non-file loader"/>
+ <int value="3" label="Font was missing require styles"/>
</enum>
<enum name="DirectWriteFontProxyError" type="int">
@@ -72988,7 +72989,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="2" label="CreateEnumeratorFromKey: invalid key"/>
<int value="3" label="CreateEnumeratorFromKey: family index out of range"/>
<int value="4" label="GetFontFiles: send failed"/>
- <int value="5" label="FontfileStream: failed to created mapped file"/>
+ <int value="5" label="FontFileStream: failed to created mapped file"/>
</enum>
<enum name="DirectWriteLoadFamilyResult" type="int">
@@ -73005,11 +73006,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="2" label="OnGetFontFiles: GetFontFamily failed"/>
<int value="3" label="InitializeDirectWrite: GetSystemFontCollection failed"/>
<int value="4" label="MapCharacters: could not find family"/>
- <int value="5" label="AddFilesforFont: create font face failed"/>
- <int value="6" label="AddFilesforFont: get font file count failed"/>
- <int value="7" label="AddFilesforFont: get font files failed"/>
- <int value="8" label="AddFilesforFont: get loader failed"/>
- <int value="9" label="AddFilesforFont: QueryInterface failed"/>
+ <int value="5" label="AddFilesForFont: create font face failed"/>
+ <int value="6" label="AddFilesForFont: get font file count failed"/>
+ <int value="7" label="AddFilesForFont: get font files failed"/>
+ <int value="8" label="AddFilesForFont: get loader failed"/>
+ <int value="9" label="AddFilesForFont: QueryInterface failed"/>
<int value="10" label="AddLocalFile: get reference key failed"/>
<int value="11" label="AddLocalFile: get path length failed"/>
<int value="12" label="AddLocalFile: get path failed"/>

Powered by Google App Engine
This is Rietveld 408576698