ExtensionInstallDialogView: Make scroll view and icon not overlap.

ExtensionInstallDialogView: Make scroll view and icon not overlap.

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions.

BUG=638093
Committed: https://crrev.com/25c3b927b343fb3388eb3f2eacd85e21e60ba9b8
Cr-Commit-Position: refs/heads/master@{#414259}

[karandeepb, 2016-08-18 04:21:30]

Description was changed from

==========
---


---

BUG=
==========

to

==========
---


---

BUG=
==========

[karandeepb, 2016-08-18 06:05:40]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 06:05:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 06:49:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 06:49:32]

Dry run: This issue passed the CQ dry run.

[karandeepb, 2016-08-19 02:23:58]

Description was changed from

==========
---


---

BUG=
==========

to

==========
ExtensionInstallDialogView: Make scroll view and icon not overlap.

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions. 

BUG=638093
==========

[karandeepb, 2016-08-19 02:24:43]

Patchset #1 (id:1) has been deleted

[karandeepb, 2016-08-19 02:30:02]

karandeepb@chromium.org changed reviewers:
+ treib@chromium.org

[karandeepb, 2016-08-19 02:30:02]

PTAL treib@. Since you are familiar with the code, can you review this before I
send it for owner's approval. I have attached the screenshots on the bug report
for the cases I tested manually. Let me know if there are any other cases worth
testing.

Also, I don't generally work on making UI changes. Is there a process to be
followed for changes as small as these?

https://codereview.chromium.org/2259723003/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/extensions/extension_install_dialog_view.cc
(right):

https://codereview.chromium.org/2259723003/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/extensions/extension_install_dialog_view.cc:455:
layout->AddView(title, 1, 1, views::GridLayout::LEADING,
This helps decrease the gap b/w the title and body that you talked about in
https://bugs.chromium.org/p/chromium/issues/detail?id=638093#c8

[Marc Treib, 2016-08-19 09:35:31]

Code LGTM (and screenshots look good to me too), but you should probably talk to
some UI folks before landing. If you don't have any UI folks nearby, maybe an
email to chrome-ui-review@google.com would be best. Or maybe the owners for this
code have some other suggestions.
Thanks!

[karandeepb, 2016-08-19 10:33:26]

karandeepb@chromium.org changed reviewers:
+ finnur@chromium.org

[karandeepb, 2016-08-19 10:33:27]

PTAL finnur@ for owner's review. Also, treib@ suggested looping in some UI
folks. Can you recommend someone? Screenshots on the bug report.

[Finnur, 2016-08-19 14:36:30]

LGTM

[karandeepb, 2016-08-24 23:59:49]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2016-08-25 00:01:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 02:19:11]

Description was changed from

==========
ExtensionInstallDialogView: Make scroll view and icon not overlap.

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions. 

BUG=638093
==========

to

==========
ExtensionInstallDialogView: Make scroll view and icon not overlap.

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions. 

BUG=638093
==========

[commit-bot: I haz the power, 2016-08-25 02:19:13]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-25 02:20:59]

Description was changed from

==========
ExtensionInstallDialogView: Make scroll view and icon not overlap.

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions. 

BUG=638093
==========

to

==========
ExtensionInstallDialogView: Make scroll view and icon not overlap.

r411889 introduced scrolling with layers and gave the scroll view in
ExtensionInstallDialog an opaque background color. This caused the scroll view
to obscure the icon for the cases where the extension prompt has no webstore
data. This is because for this case, the scroll view and the icon view in the
ExtensionInstallDialogView overlap.

This CL fixes the regression by making the scroll view and icon view not overlap
for this case. The scroll view is extended to span the full content width and a
separator is added between the title and the scroll view if the prompt shows
permissions.

BUG=638093

Committed: https://crrev.com/25c3b927b343fb3388eb3f2eacd85e21e60ba9b8
Cr-Commit-Position: refs/heads/master@{#414259}
==========

[commit-bot: I haz the power, 2016-08-25 02:21:02]

Patchset 1 (id:??) landed as
https://crrev.com/25c3b927b343fb3388eb3f2eacd85e21e60ba9b8
Cr-Commit-Position: refs/heads/master@{#414259}