Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 2259713003: Reland: arc: avoid checkbox AutomationNode issue (Closed)

Created:
4 years, 4 months ago by yawano
Modified:
4 years, 4 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org, khmel, Shuhei Takahashi, hidehiko, fukino
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: arc: avoid checkbox AutomationNode issue The original CL has caused https://crbug.com/638840. This CL includes the fix to the issue in addition to the original CL. BUG=638501, 638840 BUG=b/30906810 TEST=tested as described in the issues. Original description: arc: avoid checkbox AutomationNode issue Avoid checkbox AutomationNode issue https://crbug.com/638498 BUG=638501 BUG=b/30906810 TEST=tested as described in the issue CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f Cr-Commit-Position: refs/heads/master@{#412740} patch from issue 2254673003 at patchset 1 (http://crrev.com/2254673003#ps1) Committed: https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2 Cr-Commit-Position: refs/heads/master@{#412887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M chrome/browser/resources/chromeos/arc_support/background.js View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/main.css View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/arc_support/main.html View 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yawano
xiyuan@: PTAL. Thank you!
4 years, 4 months ago (2016-08-18 08:40:58 UTC) #5
yawano
I'll be out to Sep 2. Please check commit checkbox if this CL is l-g-t-m. ...
4 years, 4 months ago (2016-08-18 09:22:01 UTC) #7
xiyuan
lgtm It would great that we upload the original CL as PS1 for relanding so ...
4 years, 4 months ago (2016-08-18 17:48:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259713003/1
4 years, 4 months ago (2016-08-18 17:49:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 17:54:08 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:56:56 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1e2b1930480538185b0cef473949b586d96f4da2
Cr-Commit-Position: refs/heads/master@{#412887}

Powered by Google App Engine
This is Rietveld 408576698