chrome/android/webapk/libs/client/BUILD.gn - Issue 2259713002: Request upgraded WebAPK from WebAPK server if the ShellAPK version changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/libs/client/BUILD.gn

Issue 2259713002: Request upgraded WebAPK from WebAPK server if the ShellAPK version changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge branch 'master' into shell_apk_version Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/junit/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetectorTest.java ('k') | chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVersion.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/libs/client/BUILD.gn

diff --git a/chrome/android/webapk/libs/client/BUILD.gn b/chrome/android/webapk/libs/client/BUILD.gn

index 1fd1e3c66b7c3634beb36efb909afa0c2eea9c95..8d9697243ad49416773001318728ed00edfbab88 100644

--- a/chrome/android/webapk/libs/client/BUILD.gn

+++ b/chrome/android/webapk/libs/client/BUILD.gn

@@ -4,6 +4,7 @@

import("//build/config/android/rules.gni")

import("//chrome/android/webapk/libs/runtime_library_version.gni")

+import("//chrome/android/webapk/shell_apk/shell_apk_version.gni")

android_library("client_java") {

java_files = [

@@ -24,7 +25,10 @@ java_cpp_template("runtime_library_version_java") {

sources = [

"src/org/chromium/webapk/lib/client/WebApkVersion.template",

]

- defines = [ "CURRENT_RUNTIME_DEX_VERSION_VALUE=$runtime_library_version" ]

+ defines = [

+ "CURRENT_RUNTIME_DEX_VERSION_VALUE=$runtime_library_version",

+ "CURRENT_SHELL_APK_VERSION_VALUE=$shell_apk_version",

+ ]

}

junit_binary("webapk_client_junit_tests") {