Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2259613003: [turbofan] Reduce code duplication in JSTypedLowering somewhat. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
epertoso
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce code duplication in JSTypedLowering somewhat. R=epertoso@chromium.org Committed: https://crrev.com/4f603d2cafc0c96117e5231849b12c44cbc6a3ae Cr-Commit-Position: refs/heads/master@{#38705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -128 lines) Patch
M src/compiler/js-typed-lowering.h View 2 chunks +3 lines, -8 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 4 chunks +81 lines, -120 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-18 06:17:24 UTC) #1
epertoso
lgtm
4 years, 4 months ago (2016-08-18 09:16:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259613003/1
4 years, 4 months ago (2016-08-18 09:17:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 09:22:41 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 09:23:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f603d2cafc0c96117e5231849b12c44cbc6a3ae
Cr-Commit-Position: refs/heads/master@{#38705}

Powered by Google App Engine
This is Rietveld 408576698