Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2259613002: [fuchsia] Fix build. Build packages/ output. Add Directory::Exists(). (Closed)

Created:
4 years, 4 months ago by zra
Modified:
4 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] Fix build. Build packages/ output. Add Directory::Exists(). The build was broken by the addition of OS::MaxRSS, which I've added unimplemented. I need the packages/ output to get the Dart language tests going. I've added Directory::Exists() so that we can give the right error message on a missing package: import instead of crashing. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1b303e64fecc7f438f3a9db3d879f7b3f8d43c26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -8 lines) Patch
A pkg/BUILD.gn View 1 chunk +33 lines, -0 lines 0 comments Download
M runtime/bin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/directory_fuchsia.cc View 2 chunks +31 lines, -2 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A tools/list_pkg_directories.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/make_links.py View 3 chunks +17 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 4 months ago (2016-08-17 21:53:52 UTC) #2
siva
list_pkg_directories.py seems to have no changes why do you have it in the list? LGTM ...
4 years, 4 months ago (2016-08-18 01:40:55 UTC) #3
zra
On 2016/08/18 01:40:55, siva wrote: > list_pkg_directories.py seems to have no changes why do you ...
4 years, 4 months ago (2016-08-18 14:50:23 UTC) #4
zra
4 years, 4 months ago (2016-08-18 16:21:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b303e64fecc7f438f3a9db3d879f7b3f8d43c26 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698