Gerrit git cl upload: self-lgtm on TBR.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from __future__ import print_function
@@ skipping 2498 matching lines @@
             'single commit.')
       ask_for_data('About to upload; enter to confirm.')
 
     if options.reviewers or options.tbr_owners:
       change_desc.update_reviewers(options.reviewers, options.tbr_owners,
                                    change)
 
     # Extra options that can be specified at push time. Doc:
     # https://gerrit-review.googlesource.com/Documentation/user-upload.html
     refspec_opts = []
+    if change_desc.get_reviewers(tbr_only=True):
+      print('Adding self-LGTM (Code-Review +1) because of TBRs')
+      refspec_opts.append('l=Code-Review+1')
+
     if options.title:
       if not re.match(r'^[\w ]+$', options.title):
         options.title = re.sub(r'[^\w ]', '', options.title)
         print('WARNING: Patchset title may only contain alphanumeric chars '
               'and spaces. Cleaned up title:\n%s' % options.title)
         if not options.force:
           ask_for_data('Press enter to continue, Ctrl+C to abort')
       # Per doc, spaces must be converted to underscores, and Gerrit will do the
       # reverse on its side.
       refspec_opts.append('m=' + options.title.replace(' ', '_'))
 
     if options.send_mail:
       if not change_desc.get_reviewers():
         DieWithError('Must specify reviewers to send email.')
       refspec_opts.append('notify=ALL')
     else:
       refspec_opts.append('notify=NONE')
 
     cc = self.GetCCList().split(',')
     if options.cc:
       cc.extend(options.cc)
     cc = filter(None, cc)
     if cc:
       refspec_opts.extend('cc=' + email.strip() for email in cc)
 
-    if change_desc.get_reviewers():
-      refspec_opts.extend('r=' + email.strip()
-                          for email in change_desc.get_reviewers())
+    reviewers = change_desc.get_reviewers()
+    if reviewers:
+      refspec_opts.extend('r=' + email.strip() for email in reviewers)
 
     refspec_suffix = ''
     if refspec_opts:
       refspec_suffix = '%' + ','.join(refspec_opts)
       assert ' ' not in refspec_suffix, (
           'spaces not allowed in refspec: "%s"' % refspec_suffix)
     refspec = '%s:refs/for/%s%s' % (ref_to_push, branch, refspec_suffix)
 
     push_stdout = gclient_utils.CheckCallAndFilter(
         ['git', 'push', gerrit_remote, refspec],
@@ skipping 240 matching lines @@
     else:
       separator = []  # No need for separator if there are no gerrit_footers.
 
     prev_line = top_lines[-1] if top_lines else ''
     if (not presubmit_support.Change.TAG_LINE_RE.match(prev_line) or
         not presubmit_support.Change.TAG_LINE_RE.match(line)):
       top_lines.append('')
     top_lines.append(line)
     self._description_lines = top_lines + separator + gerrit_footers
 
-  def get_reviewers(self):
+  def get_reviewers(self, tbr_only=False):
     """Retrieves the list of reviewers."""
     matches = [re.match(self.R_LINE, line) for line in self._description_lines]
-    reviewers = [match.group(2).strip() for match in matches if match]
+    reviewers = [match.group(2).strip()
+                 for match in matches
+                 if match and (not tbr_only or match.group(1).upper() == 'TBR')]
     return cleanup_list(reviewers)
 
 
 def get_approving_reviewers(props):
   """Retrieves the reviewers that approved a CL from the issue properties with
   messages.
 
   Note that the list may contain reviewers that are not committer, thus are not
   considered by the CQ.
   """
@@ skipping 2294 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   setup_color.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)