Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: chrome/browser/android/shortcut_helper.h

Issue 2259553002: Make AppBannerInfoBar install WebAPK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove webpak-metrics and nits. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/shortcut_helper.h
diff --git a/chrome/browser/android/shortcut_helper.h b/chrome/browser/android/shortcut_helper.h
index a9c4b88851d25ac85752a6a7e292d7f38585c981..86c171fae5430c651708bdb678a8e09eadb9264a 100644
--- a/chrome/browser/android/shortcut_helper.h
+++ b/chrome/browser/android/shortcut_helper.h
@@ -10,6 +10,7 @@
#include "base/callback_forward.h"
#include "base/macros.h"
#include "chrome/browser/android/shortcut_info.h"
+#include "chrome/browser/android/webapk/webapk_installer.h"
#include "third_party/skia/include/core/SkBitmap.h"
namespace content {
@@ -39,7 +40,8 @@ class ShortcutHelper {
static void InstallWebApkWithSkBitmap(
content::BrowserContext* browser_context,
const ShortcutInfo& info,
- const SkBitmap& icon_bitmap);
+ const SkBitmap& icon_bitmap,
+ const WebApkInstaller::FinishCallback& callback);
// Adds a shortcut which opens in a fullscreen window to the launcher.
// |splash_image_callback| will be invoked once the Java-side operation has
@@ -57,15 +59,6 @@ class ShortcutHelper {
const ShortcutInfo& info,
const SkBitmap& icon_bitmap);
- // Called after either:
- // - A request to install the WebAPK has been sent.
- // OR
- // - WebAPK creation process fails.
- // |success| indicates whether an installation request was sent. A "true"
- // value of |success| does not guarantee that the WebAPK will be successfully
- // installed.
- static void OnBuiltWebApk(bool success);
-
// Returns the ideal size for an icon representing a web app.
static int GetIdealHomescreenIconSizeInDp();

Powered by Google App Engine
This is Rietveld 408576698