Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 2259553002: Make AppBannerInfoBar install WebAPK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove webpak-metrics and nits. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java ('k') | chrome/browser/android/banners/app_banner_infobar_delegate_android.h » ('j') | chrome/browser/android/banners/app_banner_infobar_delegate_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/strings/android_chrome_strings.grd
diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd
index cb746c9308e1b48c41cb4b01d5ee3ae91d67e1bb..556920179dd709fcfb2cd6ec9ad8c3cdec790e56 100644
--- a/chrome/android/java/strings/android_chrome_strings.grd
+++ b/chrome/android/java/strings/android_chrome_strings.grd
@@ -1527,6 +1527,9 @@ To obtain new licenses, connect to the internet and play your downloaded content
<message name="IDS_APP_BANNER_OPEN" desc="Text that indicates that clicking on the button will launch an application. [CHAR-LIMIT=25]">
Open
</message>
+ <message name="IDS_APP_BANNER_INSTALLING_WEBAPK" desc="Button text indicating that a WebAPK is being installed. [CHAR-LIMIT=25]">
+ Adding…
gone 2016/08/26 21:12:27 Why is this distinct from the regular app banner?
Xi Han 2016/08/29 14:44:52 This is a good question. I don't know why the desi
gone 2016/08/29 17:24:09 Acknowledged.
+ </message>
<!-- App banner accessibility strings, used for touch exploration -->
<message name="IDS_APP_BANNER_VIEW_NATIVE_APP_ACCESSIBILITY" desc="Accessibililty text: Describes a prompt promoting the installation of an app related to the current page, including the app's name and its rating.">
@@ -1589,6 +1592,9 @@ To obtain new licenses, connect to the internet and play your downloaded content
<message name="IDS_ADDED_TO_HOMESCREEN" desc="Indicates that the website with the specified name was added to the user's Home screen.">
<ph name="NAME">%1$s<ex>Google</ex></ph> was added to your Home screen
</message>
+ <message name="IDS_FAIL_TO_INSTALL_WEBAPK" desc="The installation of a WebAPK fails. [CHAR-LIMIT=27]">
+ Unable to add
gone 2016/08/26 21:12:27 Has this string gone through UX review? "Unable t
Xi Han 2016/08/29 14:44:52 Yes, it is from the UX review too.
gone 2016/08/29 17:24:09 Acknowledged.
+ </message>
<!-- WebsiteSettingsPopup (PageInfo dialog) -->
<message name="IDS_PAGE_INFO_SITE_SETTINGS_BUTTON" desc="Text in the button that opens a website's Site Settings from the Page Info dialog.">
« chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java ('k') | chrome/browser/android/banners/app_banner_infobar_delegate_android.h » ('j') | chrome/browser/android/banners/app_banner_infobar_delegate_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698